Skip to content

ci(kimi-desktop): strip Developer ID prefix from CSC_NAME #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wbxl2000 merged 2 commits into from
Jun 30, 2026
Merged

ci(kimi-desktop): strip Developer ID prefix from CSC_NAME #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62ed317
ci(kimi-desktop): strip Developer ID prefix from CSC_NAME
wbxl2000 Jun 30, 2026
3528f65
ci(kimi-desktop): add homepage and maintainer for linux .deb
wbxl2000 Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/desktop-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,16 @@ jobs:
certificate-p12: ${{ secrets.APPLE_CERTIFICATE_P12 }}
certificate-password: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }}

- name: Prepare CSC_NAME for electron-builder (macOS)
if: runner.os == 'macOS' && inputs.sign-macos
shell: bash
run: |
# electron-builder rejects the "Developer ID Application: " prefix in
# CSC_NAME; strip it so the certificate matches by team name + ID.
name="${APPLE_SIGNING_IDENTITY}"
name="${name#Developer ID Application: }"
echo "CSC_NAME=$name" >> "$GITHUB_ENV"

- name: Prepare notarization API key (macOS)
if: runner.os == 'macOS' && inputs.sign-macos
shell: bash
Expand All @@ -137,7 +147,6 @@ jobs:
# API key; otherwise it builds unsigned.
CSC_IDENTITY_AUTO_DISCOVERY: ${{ (runner.os == 'macOS' && inputs.sign-macos) && 'true' || 'false' }}
CSC_KEYCHAIN: ${{ env.APPLE_KEYCHAIN_PATH }}
CSC_NAME: ${{ env.APPLE_SIGNING_IDENTITY }}
KIMI_DESKTOP_NOTARIZE: ${{ (runner.os == 'macOS' && inputs.sign-macos) && 'true' || 'false' }}
APPLE_API_KEY_ID: ${{ secrets.APPLE_NOTARIZATION_KEY_ID }}
APPLE_API_ISSUER: ${{ secrets.APPLE_NOTARIZATION_ISSUER_ID }}
Expand Down
1 change: 1 addition & 0 deletions apps/kimi-desktop/electron-builder.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,5 +63,6 @@ module.exports = {
category: 'Development',
target: ['AppImage', 'deb'],
artifactName: 'KCD-Internal-${version}-${arch}.${ext}',
maintainer: 'Moonshot AI',
},
};
1 change: 1 addition & 0 deletions apps/kimi-desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"license": "MIT",
"description": "Kimi Code desktop client — an Electron shell around the Kimi web UI.",
"author": "Moonshot AI",
"homepage": "https://github.com/MoonshotAI/kimi-code",
"type": "module",
"main": "out/main.cjs",
"scripts": {
Expand Down
Loading