refactor(kosong): rename select_tools capability to dynamically_loaded_tools#1488
refactor(kosong): rename select_tools capability to dynamically_loaded_tools#1488starquakee wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 7bfca29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 92600810ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Verified and fixed in dcdc3df: the built-in catalog pruner now preserves dynamically_loaded_tools before catalogModelToCapability runs. I also swept the catalog path for other projection whitelists, and this is the only one. |
|
CI failure was a teardown flake in |
…d_tools Rename the `ModelCapability` bit from `select_tools` to `dynamically_loaded_tools` everywhere it is declared, detected, catalogued, and forwarded: kosong `ModelCapability`/catalog, agent-core capability resolution and the `toolSelectEnabled` gate, the SDK catalog-to-alias mapping, and the built-in catalog pruner's keep list. The old `select_tools` spelling is removed outright rather than kept as an alias — no catalogued model or shipped configuration used the capability, so there is nothing to migrate. Client-side vocabulary (the `select_tools` builtin tool and the `tool-select` experimental flag) is intentionally untouched.
starquakee
force-pushed
the
refactor/dynamically-loaded-tools-capability
branch
from
4e35692 to
9e64661
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9e646618ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…efactor/dynamically-loaded-tools-capability # Conflicts: # .changeset/select-tools-discard-on-compaction.md
2 participants
Related Issue
No standalone issue — terminology follow-up to #1369.
Problem
ModelCapabilitydescribes what a model can do, and its existing vocabulary is wire-level facts (image_in,thinking,tool_use). The dynamic tool loading bit shipped asselect_tools— the name of the client-side tool that drives the feature, not the model's ability. The model's ability is accepting message-level tool declarations (dynamically loaded tools); the config-to-mechanism translation belongs to the agent layer.What changed
The capability is renamed to
dynamically_loaded_toolseverywhere it is declared, detected, catalogued, and forwarded (kosongModelCapability/catalog, agent-core capability resolution and gate, SDK catalog-to-alias mapping, and the built-in catalog pruner's keep list).The old
select_toolsspelling is removed outright rather than kept as an alias: no catalogued model or shipped configuration ever used the capability, so there is nothing to migrate.Client-side vocabulary is deliberately untouched: the
select_toolsbuiltin tool and thetool-selectexperimental flag name the mechanism, which is exactly where those names belong.Checklist
gen-changesetsskill, or this PR needs no changeset. (Changeset included:@moonshot-ai/kosongpatch +@moonshot-ai/kimi-codepatch +@moonshot-ai/kimi-code-sdkpatch.)gen-docsskill, or this PR needs no doc update.