forked from vllm-project/vllm
-
Notifications
You must be signed in to change notification settings - Fork 8
Fuse Qwen3 dense-decode q-norm + RoPE into one kernel (opt-in) #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
yeahdongcn
wants to merge
2
commits into
v0.24.0-dev
Choose a base branch
from
musa/qwen3-fused-qknorm-rope
base: v0.24.0-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
vllm_musa/patches/vllm__model_executor__models__qwen3.patch.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| """MUSA cat-6 object patch: fuse Qwen3 dense-decode q-norm + neox RoPE into one | ||
| TileLang kernel (opt-in via ``VLLM_MUSA_QWEN3_FUSED_QKNORM=1``). | ||
|
|
||
| Dormant unless the env flag is set. When enabled it registers the opaque fused | ||
| custom op and rebinds ``Qwen3Attention.__init__``/``forward``; the attention | ||
| backend keeps ``reshape_and_cache`` (no backend surgery).""" | ||
|
|
||
| import os | ||
|
|
||
| import torch | ||
| from vllm.logger import init_logger | ||
|
|
||
| logger = init_logger(__name__) | ||
|
|
||
| PATCHES: list = [] | ||
|
|
||
|
|
||
| def apply() -> None: | ||
| if os.environ.get("VLLM_MUSA_QWEN3_FUSED_QKNORM", "0") != "1": | ||
| return | ||
| # MUSA: the fused op is a MUSA-only TileLang kernel; ignore the flag on any | ||
| # non-MUSA runtime so an accidentally-set env var cannot break CPU/CUDA runs. | ||
| if not (hasattr(torch.version, "musa") and torch.version.musa is not None): | ||
| logger.debug("Skipping Qwen3 fused qk-norm patch: MUSA unavailable") | ||
| return | ||
| try: | ||
| from vllm.model_executor.models.qwen3 import Qwen3Attention | ||
|
|
||
| from vllm_musa.qwen3_jit.qk_norm_rope_kv import register_and_patch | ||
| except Exception as e: | ||
| logger.debug("Skipping Qwen3 fused qk-norm patch: %s", e) | ||
| return | ||
|
|
||
| logger.info("Enabling Qwen3 fused qk-norm+RoPE decode kernel (opt-in)") | ||
| register_and_patch(Qwen3Attention) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| """Lazy JIT helpers for Qwen3 dense MUSA decode fast paths.""" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.