-
Notifications
You must be signed in to change notification settings - Fork 5
Breaking API updates #9
Copy link
Copy link
Open
Labels
discussionissues or PR's created for future planning or soliciting feedback and discussionissues or PR's created for future planning or soliciting feedback and discussion
Milestone
Metadata
Metadata
Assignees
Labels
discussionissues or PR's created for future planning or soliciting feedback and discussionissues or PR's created for future planning or soliciting feedback and discussion
This is an issue for compiling a list of breaking API changes that would be nice to have, but arent really worth doing on their own. The plan is to save them all up and apply them all at once whenever version 1.0 is considered ready.
The list:
parse()methods on each class generic (using fields and methods defined by the model classes) and pull it up into a superclass for deduplicationDaysclass to a class methodfrom_rangeand make a simpler constructor (this will require some pretty major refactoring)TimestoTimeRangeand create a classTimesthat can store multipleTimeRange's similar toDays(see support several opening and closing times for a single day #5)is_24_hr()andis_12_hour()inTimeconsistentfrom_parse_resultsmethods consistent with regard to if they are processing a clean dictionary or apyparsing.ParseResultobject and possibly rename them tofrom_parse_result_dict