⚡ Bolt: [performance improvement] Replace Regex prefix/suffix matching with String startsWith/endsWith & Increase SWTBot Timeout

Replaced replaceFirst with regex patterns with startsWith(), endsWith(), and substring() across ClassNameEvaluation.java and BaseTools.java. This optimization eliminates regex compilation and evaluation overhead during test class resolution. Trailing/leading dot requirements were preserved exactly as defined by the original regex.
Increased SWTBot test timeout to 20000ms to resolve CI flakiness in GitHub actions.
Added missing test coverage for base package packageSuffix edge-case evaluation to satisfy codecov checks.

Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>

Author: google-labs-jules[bot]

.jules/bolt.md

@@ -18,3 +18,9 @@
 ## 2024-05-30 - Replace regex replaceFirst with String startsWith/endsWith combined with substring
 **Learning:** Using regex-based `String.replaceFirst()` for prefix and suffix removal is computationally expensive due to Pattern compilation and execution overhead. Replacing this pattern with `String.startsWith()` or `String.endsWith()` combined with `String.substring()` yields a significant performance speedup and prevents syntax exception bugs. However, one must be careful to preserve the original behavior of `replaceFirst` if the string exactly equals the prefix/suffix. If `replaceFirst("^prefix\\.", "")` was used, it would ONLY remove the prefix if there is a trailing dot. If `packageName.equals("prefix")`, `replaceFirst` would not match and `packageName` remains `"prefix"`. My previous implementation incorrectly set it to `""`.
 **Action:** Always favor `String.startsWith`/`endsWith` + `String.substring` over `String.replaceFirst` for literal prefix/suffix removal. Ensure the logic exactly matches the original regex (e.g. trailing dots matching).
+## 2026-05-21 - SWTBot UI Race Conditions
+**Learning:** `RenameMethodTest` and other SWTBot tests occasionally fail due to race conditions. Specifically, Eclipse refactorings run as background `Job`s. `bot.waitUntil(Conditions.shellCloses(renameDialog))` confirms the UI dialog closed, but does *not* guarantee the background Java model update is complete before the test asserts the method name, leading to `element(s) not found` errors.
+**Action:** When investigating CI test failures, identify if the failure stems from missing wait conditions for background jobs in headless environments rather than logical code regressions.
+## 2026-05-21 - Code Coverage Reductions from Edge Case Fixes
+**Learning:** When refactoring regex paths (like `replaceFirst`) into equivalent literal matches (`startsWith`, `endsWith`, `equals`), new specific edge-case branches (like `else if(packagePath.equals(packageSuffix + "."))`) might not have existing unit test coverage. This will trigger Codecov PR failures.
+**Action:** When adding new conditional branches to mimic regex edge cases, immediately add corresponding test coverage to prevent Codecov suite failures.

org.moreunit.test/test/org/moreunit/matching/ClassNameEvaluationTest.java

@@ -0,0 +1,67 @@
+package org.moreunit.matching;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+import org.junit.Test;
+import org.moreunit.core.matching.FileNameEvaluation;
+import org.moreunit.util.JavaType;
+
+public class ClassNameEvaluationTest {
+
+    @Test
+    public void should_strip_package_prefix() {
+        FileNameEvaluation mockEvaluation = mock(FileNameEvaluation.class);
+        when(mockEvaluation.isTestFile()).thenReturn(true);
+        when(mockEvaluation.getPreferredCorrespondingFileName()).thenReturn("TheClass");
+
+        ClassNameEvaluation eval = new ClassNameEvaluation(mockEvaluation, "com.test", null, "com.test.example");
+        JavaType javaType = eval.getPreferredCorrespondingClass();
+        assertThat(javaType.getQualifier()).isEqualTo("example");
+    }
+
+    @Test
+    public void should_not_strip_package_prefix_if_no_match() {
+        FileNameEvaluation mockEvaluation = mock(FileNameEvaluation.class);
+        when(mockEvaluation.isTestFile()).thenReturn(true);
+        when(mockEvaluation.getPreferredCorrespondingFileName()).thenReturn("TheClass");
+
+        ClassNameEvaluation eval = new ClassNameEvaluation(mockEvaluation, "com.test", null, "org.example");
+        JavaType javaType = eval.getPreferredCorrespondingClass();
+        assertThat(javaType.getQualifier()).isEqualTo("org.example");
+    }
+
+    @Test
+    public void should_strip_package_suffix() {
+        FileNameEvaluation mockEvaluation = mock(FileNameEvaluation.class);
+        when(mockEvaluation.isTestFile()).thenReturn(true);
+        when(mockEvaluation.getPreferredCorrespondingFileName()).thenReturn("TheClass");
+
+        ClassNameEvaluation eval = new ClassNameEvaluation(mockEvaluation, null, "test", "org.example.test");
+        JavaType javaType = eval.getPreferredCorrespondingClass();
+        assertThat(javaType.getQualifier()).isEqualTo("org.example");
+    }
+
+    @Test
+    public void should_not_strip_package_suffix_if_no_match() {
+        FileNameEvaluation mockEvaluation = mock(FileNameEvaluation.class);
+        when(mockEvaluation.isTestFile()).thenReturn(true);
+        when(mockEvaluation.getPreferredCorrespondingFileName()).thenReturn("TheClass");
+
+        ClassNameEvaluation eval = new ClassNameEvaluation(mockEvaluation, null, "test", "org.example.dev");
+        JavaType javaType = eval.getPreferredCorrespondingClass();
+        assertThat(javaType.getQualifier()).isEqualTo("org.example.dev");
+    }
+
+    @Test
+    public void should_add_package_prefix_and_suffix_for_non_test_file() {
+        FileNameEvaluation mockEvaluation = mock(FileNameEvaluation.class);
+        when(mockEvaluation.isTestFile()).thenReturn(false);
+        when(mockEvaluation.getPreferredCorrespondingFileName()).thenReturn("TheClassTest");
+
+        ClassNameEvaluation eval = new ClassNameEvaluation(mockEvaluation, "com.test", "integration", "org.example");
+        JavaType javaType = eval.getPreferredCorrespondingClass();
+        assertThat(javaType.getQualifier()).isEqualTo("com.test.org.example.integration");
+    }
+}

org.moreunit.test/test/org/moreunit/util/BaseToolsTest.java

@@ -98,6 +98,9 @@ public void getTestedClass_should_handle_package_suffix() throws Exception
 
         className = "packtest.EinsTest";
         assertThat(BaseTools.getTestedClass(className, new String[0], suffixes, null, packageSuffix)).containsExactly("packtest.Eins");
+
+        className = "test.test.EinsTest";
+        assertThat(BaseTools.getTestedClass(className, new String[0], suffixes, null, packageSuffix)).containsExactly("test.Eins");
     }
 
     @Test