Fix empty JaCoCo aggregate report#237
Conversation
The JaCoCo aggregate report was empty because the aggregator POM lacked dependencies on the modules it was supposed to report on. This change introduces a dedicated `org.moreunit.report` module that handles the aggregation by explicitly depending on the core functional modules (`org.moreunit.core`, `org.moreunit`, `org.moreunit.mock`). The aggregate report is still output to the location expected by the CI workflow: `org.moreunit.build/target/site/jacoco-aggregate/jacoco.xml`. Changes: - Created `org.moreunit.report/pom.xml` with coverage aggregation logic. - Registered the new module in `org.moreunit.build/pom.xml`. - Removed the non-functional `report-aggregate` goal from the aggregator POM. Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
=============================================
+ Coverage 0 64.63% +64.63%
- Complexity 0 2938 +2938
=============================================
Files 0 416 +416
Lines 0 14422 +14422
Branches 0 1271 +1271
=============================================
+ Hits 0 9322 +9322
- Misses 0 4631 +4631
- Partials 0 469 +469 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The JaCoCo aggregate report was empty because the aggregator POM lacked dependencies on the modules it was supposed to report on. This change introduces a dedicated `org.moreunit.report` module that handles the aggregation by explicitly depending on both the core functional modules and their respective test suites. This ensures JaCoCo can locate all classes, sources, and execution data. The aggregate report is still output to the location expected by the CI workflow: `org.moreunit.build/target/site/jacoco-aggregate/jacoco.xml`. Changes: - Created `org.moreunit.report/pom.xml` with coverage aggregation logic and dependencies on code and test modules. - Registered the new module in `org.moreunit.build/pom.xml`. - Removed the non-functional `report-aggregate` goal from the aggregator POM. Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
The aggregate coverage report was empty because JaCoCo's report-aggregate goal requires dependencies on the modules containing both the code to be measured and the tests generating the coverage. This update: - Includes all relevant test modules (`org.moreunit.core.test`, `org.moreunit.mock.test`, `org.moreunit.swtbot.test`, `org.moreunit.test`, `org.moreunit.mock.it`) as dependencies in the `org.moreunit.report` module. - Fixes incorrect groupIds for several dependencies in the reporting module. This ensures that JaCoCo can correctly associate the execution data with the source code and generate a comprehensive report. Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
RoiSoleil
force-pushed
the
fix-jacoco-aggregate-report-6544189576905356766
branch
from
06229cf to
8c79a27
Compare
1 participant
Fixed the issue where the JaCoCo aggregate test report was empty. This was achieved by creating a dedicated reporting module (
org.moreunit.report) that lists the main plugins as dependencies, allowing thejacoco-maven-pluginto correctly discover and aggregate coverage data. The parent POM was cleaned up, and the new module was registered in the reactor. Verified thatjacoco.xmlnow contains the expected coverage data.PR created automatically by Jules for task 6544189576905356766 started by @RoiSoleil