Skip to content

🔒 Fix e.printStackTrace security and logging vulnerability #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RoiSoleil merged 2 commits into from
Apr 27, 2026
Merged

🔒 Fix e.printStackTrace security and logging vulnerability #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ffd39cb
🔒 Replace e.printStackTrace with proper LogHandler
google-labs-jules[bot] Apr 27, 2026
f8bf905
🔒 Replace e.printStackTrace with proper LogHandler
google-labs-jules[bot] Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions org.moreunit.plugin/src/org/moreunit/elements/MissingClassTreeContentProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import org.eclipse.jdt.core.JavaModelException;
import org.eclipse.jface.viewers.ITreeContentProvider;
import org.eclipse.jface.viewers.Viewer;
import org.moreunit.log.LogHandler;
import org.moreunit.ui.MissingTestsViewPart;
import org.moreunit.util.PluginTools;

Expand Down Expand Up @@ -41,7 +42,7 @@ public Object[] getChildren(Object parent)
}
catch (JavaModelException e)
{
e.printStackTrace();
LogHandler.getInstance().handleExceptionLog(e);
}
}
return null;
Expand Down Expand Up @@ -94,7 +95,7 @@ public Object[] getElements(Object inputElement)
}
catch (JavaModelException e)
{
e.printStackTrace();
LogHandler.getInstance().handleExceptionLog(e);
}
}
}
Expand Down
25 changes: 25 additions & 0 deletions org.moreunit.test/test/org/moreunit/elements/MissingClassTreeContentProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
package org.moreunit.elements;

import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

import org.eclipse.jdt.core.ICompilationUnit;
import org.eclipse.jdt.core.IPackageFragment;
import org.eclipse.jdt.core.JavaModelException;
import org.junit.Test;

public class MissingClassTreeContentProviderTest
{
@Test
public void should_not_throw_exception_but_return_null_when_java_model_exception_occurs() throws JavaModelException
{
MissingClassTreeContentProvider provider = new MissingClassTreeContentProvider();
IPackageFragment mockFragment = mock(IPackageFragment.class);
when(mockFragment.getCompilationUnits()).thenThrow(new JavaModelException(new RuntimeException("Test exception"), 1));

Object[] result = provider.getChildren(mockFragment);

assertThat(result).isNull();
}
}
Loading