Skip to content

Force re-decoration on preferences change#246

Merged
RoiSoleil merged 1 commit into
masterfrom
force-redecoration-on-preference-change-102200140677153220
Apr 28, 2026
Merged

Force re-decoration on preferences change#246
RoiSoleil merged 1 commit into
masterfrom
force-redecoration-on-preference-change-102200140677153220

Conversation

@RoiSoleil
Copy link
Copy Markdown
Contributor

Implemented forced re-decoration of Java elements when MoreUnit preferences or project properties change. This ensures that the test-case overlay icons are updated immediately without requiring a manual refresh or editor restart.

Changes:

  • In UnitDecorator: Made refreshAll() static and wrapped the label provider change event in asyncExec to ensure it runs on the UI thread.
  • In MoreUnitContants: Corrected TEST_CASE_DECORATOR to "org.moreunit.testdecorator".
  • In MoreUnitPlugin: Registered a propertyChangeListener on the plugin's preference store.
  • In MoreUnitPropertyPage: Added a call to UnitDecorator.refreshAll() after saving project-specific properties.

PR created automatically by Jules for task 102200140677153220 started by @RoiSoleil

- Refactor UnitDecorator.refreshAll() to be static and thread-safe using asyncExec.
- Fix TEST_CASE_DECORATOR constant to match the ID in plugin.xml.
- Add IPropertyChangeListener in MoreUnitPlugin to trigger refresh on global preference changes.
- Explicitly trigger refresh in MoreUnitPropertyPage when project-specific properties are saved.

Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.34%. Comparing base (056906c) to head (a40c8e2).
⚠️ Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
...reunit.plugin/src/org/moreunit/MoreUnitPlugin.java 75.00% 0 Missing and 1 partial ⚠️
...ugin/src/org/moreunit/decorator/UnitDecorator.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #246      +/-   ##
============================================
+ Coverage     73.28%   73.34%   +0.06%     
- Complexity     3234     3239       +5     
============================================
  Files           420      420              
  Lines         14435    14442       +7     
  Branches       1266     1267       +1     
============================================
+ Hits          10578    10593      +15     
+ Misses         3325     3315      -10     
- Partials        532      534       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RoiSoleil RoiSoleil merged commit 000aa0b into master Apr 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant