Skip to content

⚡ Optimize String concatenation in TestFolderPathPattern loops #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RoiSoleil merged 1 commit into from
Apr 27, 2026
+18 −5
Merged

⚡ Optimize String concatenation in TestFolderPathPattern loops #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions org.moreunit.core/src/org/moreunit/core/matching/TestFolderPathPattern.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ public class TestFolderPathPattern
TEST_PATH_VALIDATOR = compile("^/?[^/\\*\\(\\)]*" + quote(SRC_PROJECT_VARIABLE) + "[^\\*\\(\\)]*$");
}

private static final Pattern GROUP_PATTERN = Pattern.compile("\\([^\\)]+\\)");

private final String srcPathTemplate;
private final String testPathTemplate;
private final Pattern testProjectPattern;
Expand Down Expand Up @@ -204,6 +206,7 @@ private String resolveGroups(String path, String tplWithGroups, String tplWithRe
List<GroupRef> groupRefs = getGroupRefs(result);
reverse(groupRefs);

StringBuilder resultBuilder = new StringBuilder(result);
for (int i = 0; i < groupRefs.size(); i++)
{
GroupRef ref = groupRefs.get(i);
Expand All @@ -218,8 +221,9 @@ private String resolveGroups(String path, String tplWithGroups, String tplWithRe
throw new DoesNotMatchConfigurationException(analizedPath);
}

result = result.substring(0, ref.startIdx) + groupContent + result.substring(ref.endIdx);
resultBuilder.replace(ref.startIdx, ref.endIdx, groupContent);
}
result = resultBuilder.toString();
}
return result;
}
Expand Down Expand Up @@ -251,6 +255,11 @@ public SourceFolderPath getSrcPathFor(Path testPath) throws DoesNotMatchConfigur

private String replaceGroupsWithRefs(String template, List<GroupRef> groupRefs)
{
if (groupRefs.isEmpty())
{
return template;
}

Map<Integer, Integer> refIndices = new HashMap<Integer, Integer>();
int idx = 1;
for (GroupRef ref : groupRefs)
Expand All @@ -259,12 +268,16 @@ private String replaceGroupsWithRefs(String template, List<GroupRef> groupRefs)
idx++;
}

String result = template;
for (int i = 0; i < groupRefs.size(); i++)
Matcher matcher = GROUP_PATTERN.matcher(template);
StringBuffer sb = new StringBuffer();
int i = 0;
while (matcher.find() && i < groupRefs.size())
{
result = result.replaceFirst("\\([^\\)]+\\)", "\\\\" + refIndices.get(i));
matcher.appendReplacement(sb, Matcher.quoteReplacement("\\" + refIndices.get(i)));
i++;
}
return result;
matcher.appendTail(sb);
return sb.toString();
}

private String getSrcProjectName(String tstProjectName, Path tstPath) throws DoesNotMatchConfigurationException
Expand Down
Loading