⚡ Bolt: [performance improvement] Replace Matcher.replaceAll with literal String.replace in FileNameEvaluation#273
Conversation
…ing.replace Replaces instances of `Matcher.replaceAll` with literal `String.replace` in `FileNameEvaluation`. In modern JDKs (like Java 21), literal replacement avoids compiling and evaluating regex, yielding significantly faster execution and zero-allocation when the target pattern is missing. Unused static `Pattern` objects are removed. Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #273 +/- ##
============================================
- Coverage 75.13% 75.12% -0.01%
+ Complexity 3313 3312 -1
============================================
Files 422 422
Lines 14568 14565 -3
Branches 1270 1270
============================================
- Hits 10945 10942 -3
Misses 3090 3090
Partials 533 533 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
💡 What: Replaces pre-compiled
Matcher.replaceAllregex substitutions with literalString.replaceinvocations for\\E\\Q,.*, and\\Q/\\EinFileNameEvaluation.java. UnusedPatternconstants are removed.🎯 Why: In modern JDKs, using
String.replaceis significantly faster than using a regex matcher when performing literal string replacements, as it entirely avoids regex compilation and evaluation overhead. For the fast-path where characters are not found, it is zero-allocation.📊 Impact: File name evaluation mapping logic will run much faster and with fewer allocations.
🔬 Measurement: Review application responsiveness during mass file evaluation or rename refactorings. Changes verified with
mvn test.PR created automatically by Jules for task 8701462869090901963 started by @RoiSoleil