Skip to content

⚡ Bolt: [performance improvement] Replace Matcher.replaceAll with literal String.replace in FileNameEvaluation#273

Closed
RoiSoleil wants to merge 1 commit into
masterfrom
bolt/optimize-filename-evaluation-replace-8701462869090901963
Closed

⚡ Bolt: [performance improvement] Replace Matcher.replaceAll with literal String.replace in FileNameEvaluation#273
RoiSoleil wants to merge 1 commit into
masterfrom
bolt/optimize-filename-evaluation-replace-8701462869090901963

Conversation

@RoiSoleil
Copy link
Copy Markdown
Contributor

💡 What: Replaces pre-compiled Matcher.replaceAll regex substitutions with literal String.replace invocations for \\E\\Q, .*, and \\Q/\\E in FileNameEvaluation.java. Unused Pattern constants are removed.

🎯 Why: In modern JDKs, using String.replace is significantly faster than using a regex matcher when performing literal string replacements, as it entirely avoids regex compilation and evaluation overhead. For the fast-path where characters are not found, it is zero-allocation.

📊 Impact: File name evaluation mapping logic will run much faster and with fewer allocations.

🔬 Measurement: Review application responsiveness during mass file evaluation or rename refactorings. Changes verified with mvn test.


PR created automatically by Jules for task 8701462869090901963 started by @RoiSoleil

…ing.replace

Replaces instances of `Matcher.replaceAll` with literal `String.replace` in `FileNameEvaluation`. In modern JDKs (like Java 21), literal replacement avoids compiling and evaluating regex, yielding significantly faster execution and zero-allocation when the target pattern is missing. Unused static `Pattern` objects are removed.

Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.12%. Comparing base (3d45358) to head (0d54605).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #273      +/-   ##
============================================
- Coverage     75.13%   75.12%   -0.01%     
+ Complexity     3313     3312       -1     
============================================
  Files           422      422              
  Lines         14568    14565       -3     
  Branches       1270     1270              
============================================
- Hits          10945    10942       -3     
  Misses         3090     3090              
  Partials        533      533              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RoiSoleil RoiSoleil closed this May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant