⚡ Bolt: Optimize regex replaceAll with literal String.replace#275
Conversation
…uation Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #275 +/- ##
============================================
- Coverage 75.13% 75.12% -0.01%
+ Complexity 3313 3312 -1
============================================
Files 422 422
Lines 14568 14565 -3
Branches 1270 1270
============================================
- Hits 10945 10942 -3
Misses 3090 3090
Partials 533 533 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
💡 What: Replaced
Matcher.replaceAllwith literalString.replaceinFileNameEvaluation.java. Also removed the now-unused precompiledPatterninstances and imports.🎯 Why: In modern JDKs (Java 21 in this project), using
String.replace()for literal string replacements avoids regex compilation and state-machine traversal overhead, providing a significant performance improvement.📊 Impact: Reduces GC pressure and CPU overhead during filename evaluation, which is a frequent operation when matching tests to sources.
🔬 Measurement: Verify by running
xvfb-run -a mvn -f org.moreunit.build/pom.xml clean verifyand confirming all tests inFileNameEvaluationTestcontinue to pass.PR created automatically by Jules for task 15904077605095254635 started by @RoiSoleil