Skip to content

Commit 3e8a5be

Browse files
committed
Thread/Scheduler: Minor fixes
1 parent 1c304cc commit 3e8a5be

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

.clang-format

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@ BinPackParameters: false
9595
BinPackArguments: false
9696
BreakAfterAttributes: Never
9797
BreakBeforeTernaryOperators: false
98+
BreakBeforeBinaryOperators: NonAssignment
9899
BreakInheritanceList: AfterColon
99100
BreakConstructorInitializers: AfterColon
100101

modules/Thread/Scheduler.mpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,12 +143,11 @@ export namespace CppUtils::Thread
143143
return;
144144

145145
const auto endTime = first->time + m_step;
146-
for (auto it = std::begin(set); it != std::end(set) and (*it)->time <= endTime; ++it)
146+
for (auto it = std::begin(set); it != std::end(set) and (*it)->time <= endTime;)
147147
{
148148
auto item = *it;
149-
++it;
149+
it = set.erase(it);
150150
map.erase(item->id);
151-
set.erase(item);
152151
if (not item->cancelled)
153152
{
154153
accessor.getLockGuard().unlock();

tests/Terminal/Canvas.mpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import CppUtils;
55

66
export namespace CppUtils::UnitTest::Terminal::Canvas
77
{
8-
inline auto _ = TestSuite{"Terminal/Canvas", {"UnitTest", "Execution/Planner"}, [](auto& suite) {
8+
inline auto _ = TestSuite{"Terminal/Canvas", {"UnitTest", "Thread/Scheduler"}, [](auto& suite) {
99
using namespace std::literals;
1010
using namespace std::chrono_literals;
1111

@@ -42,9 +42,9 @@ export namespace CppUtils::UnitTest::Terminal::Canvas
4242
}
4343
});
4444

45-
suite.addTest("Fill with planner", [&] {
45+
suite.addTest("Fill with scheduler", [&] {
4646
auto canvas = CppUtils::Terminal::v2::Canvas{CppUtils::Container::Size2{10, 5}};
47-
auto planner = CppUtils::Thread::Planner{};
47+
auto scheduler = CppUtils::Thread::Scheduler{};
4848
const auto chars = "-\\|/"sv;
4949
auto loop = 0uz, frame = 0uz;
5050
auto updateFrame = [&](this const auto& self) -> void {
@@ -59,7 +59,7 @@ export namespace CppUtils::UnitTest::Terminal::Canvas
5959
return;
6060
}
6161
}
62-
planner.schedule(self, 50ms);
62+
scheduler.schedule(self, 50ms);
6363
};
6464
updateFrame();
6565
canvas.wait();

0 commit comments

Comments
 (0)