Skip to content

Commit 945d9cc

Browse files
committed
Minor fixes
1 parent 445a637 commit 945d9cc

3 files changed

Lines changed: 15 additions & 19 deletions

File tree

modules/Container/DependencyGraph.mpp

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,54 +25,54 @@ export namespace CppUtils::Container
2525
std::vector<Key> dependencies;
2626
};
2727

28-
[[nodiscard]] auto contains(const Key& key) const noexcept -> bool
28+
[[nodiscard]] inline auto contains(const Key& key) const noexcept -> bool
2929
{
3030
return nodes.contains(key);
3131
}
3232

33-
auto insert(const Key& key, Value&& value) -> void
33+
inline auto insert(const Key& key, Value&& value) -> void
3434
{
3535
nodes[key].value = std::forward<Value>(value);
3636
}
3737

38-
auto remove(const Key& key) -> void
38+
inline auto remove(const Key& key) -> void
3939
{
4040
nodes.erase(key);
4141
for (auto& [_, node] : nodes)
4242
std::erase(node.dependencies, key);
4343
}
4444

45-
[[nodiscard]] auto operator[](const Key& key) const noexcept -> const Value&
45+
[[nodiscard]] inline auto operator[](const Key& key) const noexcept -> const Value&
4646
{
4747
return nodes[key].value;
4848
}
4949

50-
[[nodiscard]] auto operator[](const Key& key) noexcept -> Value&
50+
[[nodiscard]] inline auto operator[](const Key& key) noexcept -> Value&
5151
{
5252
return nodes[key].value;
5353
}
5454

55-
auto addDependency(const Key& key, const Key& dependency) -> void
55+
inline auto addDependency(const Key& key, const Key& dependency) -> void
5656
{
5757
nodes[key].dependencies.push_back(dependency);
5858
}
5959

60-
auto removeDependency(const Key& key, const Key& dependency) -> void
60+
inline auto removeDependency(const Key& key, const Key& dependency) -> void
6161
{
6262
std::erase(nodes[key].dependencies, dependency);
6363
}
6464

65-
[[nodiscard]] auto getDependencies(const Key& key) const noexcept -> decltype(auto)
65+
[[nodiscard]] inline auto getDependencies(const Key& key) const noexcept -> decltype(auto)
6666
{
6767
return nodes.at(key).dependencies;
6868
}
6969

70-
[[nodiscard]] auto getDependencies(const Key& key) noexcept -> decltype(auto)
70+
[[nodiscard]] inline auto getDependencies(const Key& key) noexcept -> decltype(auto)
7171
{
7272
return nodes[key].dependencies;
7373
}
7474

75-
auto hasCycle() -> bool
75+
[[nodiscard]] inline auto hasCycle() -> bool
7676
{
7777
auto visited = std::unordered_map<Key, VisitState>{};
7878

@@ -103,7 +103,7 @@ export namespace CppUtils::Container
103103
return false;
104104
}
105105

106-
auto forEach(auto&& function) -> std::expected<void, std::string>
106+
inline auto forEach(auto&& function) -> std::expected<void, std::string>
107107
{
108108
using namespace std::literals;
109109

modules/System/Main.mpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ export module CppUtils.System.Main;
22

33
export namespace CppUtils
44
{
5-
constexpr auto exitSuccess = 0;
6-
constexpr auto exitFailure = 1;
5+
inline constexpr auto exitSuccess = 0;
6+
inline constexpr auto exitFailure = 1;
77
}

modules/UnitTest/UnitTest.mpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,9 @@ import CppUtils.Container;
1111
import CppUtils.Logger;
1212
import CppUtils.String;
1313
import CppUtils.Terminal;
14-
export import CppUtils.UnitTest.DummyObject;
14+
import CppUtils.System.Main;
1515

16-
namespace
17-
{
18-
inline constexpr auto exitSuccess = 0;
19-
inline constexpr auto exitFailure = 1;
20-
}
16+
export import CppUtils.UnitTest.DummyObject;
2117

2218
namespace CppUtils::UnitTest
2319
{

0 commit comments

Comments
 (0)