Fix staking refresh to ensure balance updates are applied#216
Merged
Conversation
The daily staking refresh cron was writing ledger entries but failing to update credit_account_balances for some users (e.g. user 352). Root cause was two compounding issues: 1. get_or_create_balance() was called without for_update=True, so a Redis cache hit returned a detached ORM object not tracked by the SQLAlchemy session. Modifying it and calling db.commit() was a silent no-op for the balance row. 2. create_ledger_entry() used auto_commit=True (default), committing the ledger row in its own transaction. If anything failed before the subsequent balance commit, the ledger entry persisted while the balance rollback left staking_daily_amount/staking_available at zero. Fix: use for_update=True to always get a session-managed row from the DB (bypassing cache), and auto_commit=False so the ledger entry and balance update are committed in a single atomic transaction. Made-with: Cursor
…-balance fix: prevent staking refresh from silently losing balance updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.