Forced metafunction resolver to check arity on monoarity functions#324
Open
WoodchuckXL wants to merge 1 commit into
Open
Forced metafunction resolver to check arity on monoarity functions#324WoodchuckXL wants to merge 1 commit into
WoodchuckXL wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #322.
This forces the metafunction resolution compiler to add a step to the beginning of the multiple dispatch resolver of all mono-arity functions(functions whose implementations all take the same number of arguments) which ensures that the function was passed the correct number of arguments. This check was already in place for multi-arity functions so this fix just affects the mono-arity case.
Note
This fix has the side effect of rendering an error inside the matrix class obsolete, this is because this class would manually check the types of its arguments, but with multiple dispatch fixed, the error will be caught before it ever reaches the matrix class.