Sort bind/lookup/formatted vars by logical name before mapping

Previously sortByName ran after List.map, sorting on the generated
property name (e.g. field@odata.bind). Now sorting is inline on the
source logical name, which can produce a different output order.

Author: Mosh-K

src/CreateTypeScript/CreateWebEntities.fs

@@ -78,6 +78,7 @@ let getBindVars (nameMap: Map<string, EntityInfo>) (filter: XrmAttribute -> bool
 
   entity.manyToOneRelationships
   |> List.filter (fun rel -> Map.tryFind rel.ReferencingAttribute attrMap |> Option.exists filter)
+  |> List.sortBy (fun rel -> rel.ReferencingEntityNavigationPropertyName)
   |> List.map (fun rel ->
     let eInfo = Map.find rel.ReferencedEntity nameMap
 
@@ -93,19 +94,18 @@ let getBindVars (nameMap: Map<string, EntityInfo>) (filter: XrmAttribute -> bool
       Comment.Basic eInfo.DisplayName,
       optional = true
     ))
-  |> sortByName
 
 let getLookupValueVars (attrs: XrmAttribute list) =
   attrs
   |> List.filter (fun a -> a.specialType = SpecialType.EntityReference)
+  |> List.sortBy (fun a -> a.logicalName)
   |> List.map (fun a ->
     Variable.Create(
       valueInfix a.logicalName,
       TsType.String,
       getAttributeComment a None,
       optional = true
     ))
-  |> sortByName
 
 let private toInterfaceName forWrite schemaName =
   if forWrite then $"{schemaName}.{CREATE_INTERFACE_NAME}" else schemaName
@@ -206,18 +206,19 @@ let getManyToManyVars nameMap (schemaNames: Set<string>) forWrite (entity: XrmEn
 let getFormattedVars (entity: XrmEntity) =
   entity.attributes
   |> List.filter hasFormattedValue
+  |> List.sortBy (fun attr -> attr.logicalName)
   |> List.map (fun attr ->
     Variable.Create(
       formattedName attr,
       TsType.String,
       getAttributeComment attr (Some entity.optionSets),
       optional = true
     ))
-  |> sortByName
 
 let getLookupNameVars (attrs: XrmAttribute list) =
   attrs
   |> List.filter (fun a -> a.specialType = SpecialType.EntityReference)
+  |> List.sortBy (fun a -> a.logicalName)
   |> List.map (fun a ->
     let vType =
       match a.targetEntitySets with
@@ -234,7 +235,6 @@ let getLookupNameVars (attrs: XrmAttribute list) =
       Comment.Attribute(a.displayName, tes = a.targetEntitySets),
       optional = true
     ))
-  |> sortByName
 
 let getScalarVars (filter: XrmAttribute -> bool) (entity: XrmEntity) =
   entity.attributes