Route auto-apply pref read through YieldController overlay

The auto-apply read at orderSimultaneousSa was reading the host's local
FPref, so remote clients silently inherited the host's reorder-mode
setting — meaning Auto mode skipped the prompt for remote clients
regardless of their own setting.

Add UI_REORDER_SIMULTANEOUS_ABILITY_MODE to SYNCED_PREFS so the seed
snapshot ships the client's value at match start, and read via
getStringPref() (override wins, FModel fallback) instead of FModel
directly. Local-host PCH continues to fall through to FModel since
prefOverrides is only populated on remote-player proxies.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: MostCromulent

forge-gui/src/main/java/forge/gamemodes/match/YieldController.java

@@ -41,7 +41,7 @@
  */
 public class YieldController {
 
-    /** Yield FPrefs synced per-PCH; enumerated here so the client snapshot includes every value, not just touched overrides.
+    /** Controller-scoped FPrefs synced per-PCH; enumerated here so the client snapshot includes every value, not just touched overrides.
      * Stored String-typed (see {@link forge.localinstance.properties.PreferencesStore}); consumers parse via {@link #getBoolPref}/{@link #getStringPref} according to the pref's expected type. */
     private static final EnumSet<FPref> SYNCED_PREFS = EnumSet.of(
             FPref.YIELD_INTERRUPT_ON_ATTACKERS,
@@ -58,7 +58,8 @@ public class YieldController {
             FPref.YIELD_SUPPRESS_AFTER_END,
             FPref.YIELD_AVAILABLE_ACTIONS_BUDGET_MS,
             FPref.YIELD_DECLINE_SCOPE_STACK_YIELD,
-            FPref.YIELD_DECLINE_SCOPE_NO_ACTIONS);
+            FPref.YIELD_DECLINE_SCOPE_NO_ACTIONS,
+            FPref.UI_REORDER_SIMULTANEOUS_ABILITY_MODE);
 
     private final PlayerControllerHuman owner;
 

forge-gui/src/main/java/forge/player/PlayerControllerHuman.java

@@ -2024,7 +2024,7 @@ public List<SpellAbility> orderSimultaneousSa(List<SpellAbility> activePlayerSAs
         }
         if (needPrompt) {
             List<Integer> savedOrder = orderedSALookup.get(saLookupKey.toString());
-            String mode = FModel.getPreferences().getPref(FPref.UI_REORDER_SIMULTANEOUS_ABILITY_MODE);
+            String mode = yieldController.getStringPref(FPref.UI_REORDER_SIMULTANEOUS_ABILITY_MODE);
 
             if (savedOrder != null && ForgeConstants.REORDER_SIMULTANEOUS_AUTO.equals(mode)) {
                 List<SpellAbility> orderedSAs = Lists.newArrayListWithCapacity(savedOrder.size());