ch09: fix signature and usage of logFilename in exercise_b#503
Closed
eush77 wants to merge 2 commits intoMostlyAdequate:masterfrom
Closed
ch09: fix signature and usage of logFilename in exercise_b#503eush77 wants to merge 2 commits intoMostlyAdequate:masterfrom
eush77 wants to merge 2 commits intoMostlyAdequate:masterfrom
Conversation
This fixes type signature of function `logFilename` constructed in exercise_b, and changes its usage to match the type of the `()` parameter.
Member
|
Hey, good catch. I went for a slightly different approach and fixed the definition of see also: 5a464d1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes type signature of function
logFilenameconstructed in exercise_b, and changes its usage to match the type of the()parameter (see #500 (comment)).