Merge pull request #174 from MostroP2P/fix/pow-detect-no-response

fix(pow): filter wait_for_dm notifications so PoW detection actually fires

Author: grunch

docs/pow_error_handling.md

@@ -170,6 +170,26 @@ Add an `&Context` parameter? Look at the signature today —
 passed. We just need to grant the helper access to `ctx.client` and
 `ctx.mostro_pubkey` (already does).
 
+#### 4.3.1 Notification leak from the concurrent probe
+
+`client.notifications()` is a **global** broadcast: every event seen by
+any active subscription or fetch lands on the same channel
+(`nostr-relay-pool::relay::inner::send_notification`). The spawned PoW
+probe issues its own subscription for kind‑38385 events to read the
+required difficulty — those info events show up on the same broadcast
+the wait loop is consuming. Without an application‑side filter, the
+loop returns the info event as the "first event" and short‑circuits the
+wait before mostrod has even had a chance to (silently) drop the
+request, surfacing further downstream as `"No response received from
+Mostro"`.
+
+Fix: the notification loop mirrors the subscription filter explicitly —
+only `Kind::GiftWrap` events whose `p` tags contain `trade_keys.public_key()`
+escape the loop. Anything else (kind‑38385 info, replaceable
+status events, gift wraps for other trade keys) is dropped on the floor
+so the wait properly reaches its timeout, where the PoW probe result
+escalates to `PowRequirementUnmet`.
+
 ### 4.4 `add_bond_invoice` interplay
 
 `add_bond_invoice` treats `WaitForDmTimeout` as the happy path (Mostro pays

src/util/messaging.rs

@@ -317,11 +317,12 @@ where
     F: std::future::Future<Output = Result<()>> + Send,
 {
     let trade_keys = order_trade_keys.unwrap_or(&ctx.trade_keys);
+    let trade_pubkey = trade_keys.public_key();
     let mut notifications = ctx.client.notifications();
     let opts =
         SubscribeAutoCloseOptions::default().exit_policy(ReqExitPolicy::WaitForEventsAfterEOSE(1));
     let subscription = Filter::new()
-        .pubkey(trade_keys.public_key())
+        .pubkey(trade_pubkey)
         .kind(nostr_sdk::Kind::GiftWrap)
         .limit(0);
     ctx.client.subscribe(subscription, Some(opts)).await?;
@@ -340,11 +341,27 @@ where
         ctx.mostro_pubkey,
     ));
 
-    // Wait for the DM or gift wrap event
+    // Wait for the DM or gift wrap event.
+    //
+    // `client.notifications()` is the **global** broadcast for every event
+    // any active subscription / fetch sees — including the kind-38385 info
+    // event coming back from the spawned PoW probe above. Without an
+    // application-side filter, that info event would race ahead of the real
+    // reply and short-circuit the wait, surfacing as "No response received
+    // from Mostro" further downstream. So mirror the subscription filter
+    // here and only accept GiftWraps tagged to our trade key.
     let waited = tokio::time::timeout(super::events::FETCH_EVENTS_TIMEOUT, async move {
         loop {
             match notifications.recv().await {
-                Ok(RelayPoolNotification::Event { event, .. }) => return Ok(*event),
+                Ok(RelayPoolNotification::Event { event, .. }) => {
+                    if event.kind != nostr_sdk::Kind::GiftWrap {
+                        continue;
+                    }
+                    if !event.tags.public_keys().any(|pk| *pk == trade_pubkey) {
+                        continue;
+                    }
+                    return Ok(*event);
+                }
                 Ok(_) => continue,
                 Err(e) => {
                     return Err(anyhow::anyhow!("Error receiving notification: {:?}", e));