fix(price): repair test-only price seeding broken by #753/#770 merge skew

[grunch]

Problem

main does not compile under cargo test (cargo check --all-targets / cargo clippy --all-targets) since the last two merges crossed:

• feat(price): Phase 1 — Yadio provider + PriceManager wiring #753 removed the BITCOIN_PRICES static when it migrated price reads to the new PriceManager.
• feat(bond): Phase 6 — range-order maker bond with proportional slashes #770 (developed in parallel, merged after) added BitcoinPriceManager::set_price_for_test, which writes to that now-removed static, plus a util.rs test that calls it.

error[E0425]: cannot find value `BITCOIN_PRICES` in this scope --> src/bitcoin_price.rs:31:9
error[E0433]: failed to resolve: use of undeclared type `BitcoinPriceManager` --> src/util.rs:1936:9

Fix

Re-point the test seam at a small #[cfg(test)] override map (price::test_price_overrides) consulted by price::get_bitcoin_price before the global manager:

• Unit tests keep seeding deterministic prices per unique currency code, exactly as the feat(bond): Phase 6 — range-order maker bond with proportional slashes #770 test intended.
• No global PriceManager install in tests — its OnceLock would leak one test's configuration into every other test in the binary.
• Zero impact on non-test builds: the map and the lookup are both cfg(test).

Checks

• cargo test: 426 passed
• cargo clippy --all-targets --all-features: clean
• cargo fmt: clean

🤖 Generated with Claude Code

Summary by CodeRabbit

• Refactor
  • Restructured internal test price override handling for improved test isolation and consistency.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8a2dc859-4204-4733-836f-d1f712bd83d8

📥 Commits

Reviewing files that changed from the base of the PR and between af8f05d and c80db44.

📒 Files selected for processing (3)

• src/bitcoin_price.rs
• src/price/mod.rs
• src/util.rs

---

Walkthrough

This PR consolidates Bitcoin price test overrides into a centralized, thread-safe shared map. The new infrastructure in price/mod.rs exposes a per-currency override mechanism that the real get_bitcoin_price checks first under test mode, while the legacy BitcoinPriceManager::set_price_for_test helper is wired to use this shared map instead of maintaining its own in-memory cache.

Changes

Test price override consolidation

Layer / File(s)	Summary
Test price override infrastructure and integration src/price/mod.rs	A process-wide OnceLock<RwLock<HashMap<String, f64>>> backed override map is added via test_price_overrides(). The get_bitcoin_price function is updated to consult this map under #[cfg(test)] and return overridden prices when available, falling back to live retrieval otherwise.
Legacy test helper integration src/bitcoin_price.rs	BitcoinPriceManager::set_price_for_test is updated to seed the new shared override map via crate::price::test_price_overrides() instead of the legacy per-module cache. Documentation describes override-map seeding and test isolation via per-test unique currencies.
Test module import src/util.rs	BitcoinPriceManager is imported into the test module to support unit tests that set deterministic cached prices for calculations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• MostroP2P/mostro#747: Both PRs touch src/price/mod.rs and relate to BTC price retrieval logic by integrating get_bitcoin_price in test contexts atop the Phase-0 price module foundation.

Suggested reviewers

• AndreaDiazCorreia
• BraCR10
• Catrya
• mostronatorcoder

Poem

🐰 A currency cache once scattered and sparse,
Now gathered as one in a lock, thread-safe farce!
Test prices unified, no more duplicated state—
The override map handles them all, oh so great!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(price): repair test-only price seeding broken by #753/#770 merge skew' accurately describes the main change: fixing a broken test-only price seeding mechanism that resulted from merge conflicts between two prior PRs.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/price-test-seed-compile

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}