Skip to content

fix(restore-session): scrub Nostr keys from log lines #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grunch merged 1 commit into from
Jul 23, 2026
+8 −6
Merged

fix(restore-session): scrub Nostr keys from log lines #835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/app/restore_session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ pub async fn restore_session_action(
return Err(MostroCantDo(CantDoReason::InvalidPubkey));
}

tracing::info!(
"Starting background restore session for master key: {}",
master_key
);
// No key in the log line — master_key is the user's persistent Nostr
// identity, not a per-trade ephemeral one (AGENTS.md: scrub Nostr keys
// from logs).
tracing::info!("Starting background restore session");

// Create a new manager for this specific restore session
let manager = RestoreSessionManager::new();
Expand Down Expand Up @@ -99,7 +99,8 @@ async fn send_restore_session_response(
)
.await;

tracing::info!("Restore session response sent to user {}", trade_key,);
// No key in the log line (AGENTS.md: scrub Nostr keys from logs).
tracing::info!("Restore session response sent to user");

Ok(())
}
Expand All @@ -112,7 +113,8 @@ async fn send_restore_session_timeout(trade_key: &str) -> Result<(), MostroError
// Send timeout message without payload since Text doesn't exist
enqueue_restore_session_msg(None, trade_pubkey).await;

tracing::warn!("Restore session timed out for user: {}", trade_key);
// No key in the log line (AGENTS.md: scrub Nostr keys from logs).
tracing::warn!("Restore session timed out for user");

Ok(())
}
Expand Down