Skip to content

🐛 fix multi-add#697

Open
felinae98 wants to merge 1 commit into
mainfrom
multi-add
Open

🐛 fix multi-add#697
felinae98 wants to merge 1 commit into
mainfrom
multi-add

Conversation

@felinae98

@felinae98 felinae98 commented Mar 12, 2025

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@felinae98 felinae98 added the bug Something isn't working label Mar 12, 2025
@netlify

netlify Bot commented Mar 12, 2025

Copy link
Copy Markdown

Deploy Preview for nonebot-bison ready!

Name Link
🔨 Latest commit ba71ccc
🔍 Latest deploy log https://app.netlify.com/sites/nonebot-bison/deploys/67d1b28c293c790008411cef
😎 Deploy Preview https://deploy-preview-697--nonebot-bison.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov

codecov Bot commented Mar 12, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.04%. Comparing base (26d060f) to head (ba71ccc).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #697   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files          98       98           
  Lines        5542     5542           
=======================================
  Hits         4713     4713           
  Misses        829      829           
Flag Coverage Δ
smoke-test ∅ <100.00%> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@suyiiyii
suyiiyii requested a review from Copilot March 29, 2025 12:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses the multi-add bug by introducing row-level locking via .with_for_update() on both the user and target queries.

  • Update the user query to lock the selected row.
  • Update the target query with a similar lock to prevent concurrent modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants