fix: potentially address subtle bug with file paths getting a trailing slash (#161)

Author: Cervator

gestalt-module/src/main/java/org/terasology/gestalt/module/resources/ClasspathFileSource.java

@@ -102,7 +102,7 @@ public Optional<FileReference> getFile(List<String> filepath) {
         if (filepath.stream().anyMatch(s -> s.equals(".."))) {
             return Optional.empty();
         }
-        String fullpath = buildPathString(filepath);
+        String fullpath = buildPathString(filepath, false);
         if (classLoader.getResource(fullpath) != null) {
             return Optional.of(new ClasspathSourceFileReference(fullpath, extractSubpath(basePath, fullpath), classLoader));
         } else {
@@ -112,7 +112,7 @@ public Optional<FileReference> getFile(List<String> filepath) {
 
     @Override
     public Collection<FileReference> getFilesInPath(boolean recursive, List<String> path) {
-        String fullPath = buildPathString(path);
+        String fullPath = buildPathString(path, true);
         Stream<String> candidates = files
                 .stream()
                 .filter(file -> file.startsWith(fullPath))
@@ -129,7 +129,7 @@ public Collection<FileReference> getFilesInPath(boolean recursive, List<String>
 
     @Override
     public Set<String> getSubpaths(List<String> path) {
-        String fullPath = buildPathString(path);
+        String fullPath = buildPathString(path, true);
         return files
                 .stream()
                 .filter(file -> file.startsWith(fullPath))
@@ -141,12 +141,15 @@ public Set<String> getSubpaths(List<String> path) {
                 .collect(Collectors.toSet());
     }
 
-    private String buildPathString(List<String> path) {
+    private String buildPathString(List<String> path, boolean isDirectory) {
         String fullPath;
         if (path.isEmpty() || (path.size() == 1 && path.get(0).isEmpty())) {
             fullPath = basePath;
         } else {
-            fullPath = basePath + CLASS_PATH_JOINER.join(path) + CLASS_PATH_SEPARATOR;
+            fullPath = basePath + CLASS_PATH_JOINER.join(path);
+            if (isDirectory) {
+                fullPath += CLASS_PATH_SEPARATOR;
+            }
         }
         return fullPath;
     }