Add get_horizontal_link_block to return the horizontal link block for…#16190
Merged
Conversation
adalcima
marked this pull request as ready for review
July 9, 2026 17:16
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
ramram-mf
approved these changes
Jul 13, 2026
ramram-mf
left a comment
ramram-mf
left a comment
Collaborator
There was a problem hiding this comment.
LGTM lets merge it to the feature branch and keep shaping this.
adalcima
merged commit Jul 13, 2026
24a7ca4
into
feature/horizontal-link-block-implementation
10 of 11 checks passed
adalcima
deleted the
TP1-4042-Add-method-for-horizontal-link-block-inheritance-logic
branch
July 13, 2026 16:01
ramram-mf
added a commit
that referenced
this pull request
Jul 16, 2026
* Add get_horizontal_link_block to return the horizontal link block for… (#16190) * Add get_horizontal_link_block to return the horizontal link block for General page * Fix linting issues * TP1-4041 Implement horizontal link block (#16204) * TP1-4041 Implement horizontal link block * TP1-4041 Fix horizontal link block formatting * TP1-4041 Refine horizontal link interactions * TP1-4041 Address horizontal link design feedback * TP1-4041 Extend horizontal divider through menu padding * TP1-4041 Use tight horizontal divider artwork --------- Co-authored-by: adalcima <cima.adalberto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prepares
GeneralPagemodel to support an inherited horizontal link block snippet.Related issue: TP1-4042
Main changes:
get_horizontal_link_blockmethodGeneralPagenodesTODOplaceholder for the missinghorizontal_link_blockFK field (to be implemented in this ticket TP1-4041)Still pending (not in this PR)
HorizontalNavBarsnippet model (just a suggested name){% with nav=page.get_horizontal_link_block %}...{% endwith %}