Fix flaky test showing NS_BINDING_ABORTED in Firefox

Author: ksy36

server/reportmanager/templates/layouts/layout_base.html

@@ -32,46 +32,6 @@
   <script src="{% static 'js/params.js' %}"/></script>
   <script src="{% static 'js/cookie-csrf.js' %}"/></script>
 
-  <script>
-  (() => {
-    const notify_badge_class = 'badge';
-    const notify_api_url = '/inbox/notifications/api/unread_count/';
-    const notify_fetch_count = '5';
-    const notify_refresh_period = 0;
-    const consecutive_misfires = 0;
-
-    function fill_notification_badge(data) {
-      const badges = document.getElementsByClassName(notify_badge_class);
-      for (let i = 0; i < badges.length|0; i++) {
-        badges[i].innerHTML = data;
-      }
-    }
-
-    function fetch_api_data() {
-      fetch(notify_api_url+'?max='+notify_fetch_count, {credentials: 'same-origin'})
-      .then(response => {
-        if (response.ok) {
-          response.json()
-          .then(data => {
-            fill_notification_badge(data.unread_count);
-          })
-          if (notify_refresh_period) {
-            setTimeout(fetch_api_data, notify_refresh_period);
-          }
-        } else {
-          swal('Oops', E_SERVER_ERROR, 'error');
-          console.debug(response);
-        }
-      })
-      .catch(e => {
-        fill_notification_badge('!');
-      });
-    }
-
-    document.addEventListener("DOMContentLoaded", fetch_api_data)
-  })()
-  </script>
-
 {% endblock js%}
 {% if debug %}
   <script>

tests/e2e/page_objects/base.py

@@ -12,4 +12,6 @@ def __init__(self, page, live_server):
 
     def navigate(self):
         """Navigate to this page's URL."""
+        if self.page.url != "about:blank":
+            self.page.wait_for_load_state("networkidle")
         self.page.goto(f"{self.live_server.url}{self.url}")

tests/e2e/page_objects/login.py

@@ -17,8 +17,8 @@ def login(self, email, password):
         self.navigate()
         self.username_input.fill(email)
         self.password_input.fill(password)
-        self.submit_button.click()
-        self.page.wait_for_load_state("networkidle")
+        with self.page.expect_navigation():
+            self.submit_button.click()
 
         assert not self.page.url.endswith("/login/"), (
             f"Login failed: still on login page ({self.page.url})"