Skip to content

Add triage statuses#188

Merged
ksy36 merged 7 commits into
mainfrom
triage_statuses
May 11, 2026
Merged

Add triage statuses#188
ksy36 merged 7 commits into
mainfrom
triage_statuses

Conversation

@ksy36

@ksy36 ksy36 commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

Changes "Mark triaged until " to "Mark triaged with a status"

Screenshot 2026-05-04 at 1 21 42 PM

@ksy36 ksy36 force-pushed the triage_statuses branch 3 times, most recently from 05368b4 to 5f08494 Compare May 4, 2026 13:52
@ksy36 ksy36 marked this pull request as ready for review May 4, 2026 18:11
triage_status='worksforme',
triaged_at=now
)

@ksy36 ksy36 May 4, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 3 migrations:

  1. Adds triage_status and triaged_at fields
  2. All existing triaged issues are moved to worksforme with triaged_at set to previous hide_until minus 4 weeks
  3. hide_until field is removed

now = timezone.now()
Bucket.objects.filter(hide_until__lte=now).update(hide_until=None)


@ksy36 ksy36 May 4, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this existing unhide_buckets command and adding a new command that would reset triage status based on spikes in a separate PR #194

@ksy36 ksy36 requested a review from jgraham May 4, 2026 18:21
@ksy36 ksy36 force-pushed the triage_statuses branch from 6d41477 to db32b1a Compare May 4, 2026 20:11
@jgraham jgraham closed this May 7, 2026
@jgraham jgraham reopened this May 7, 2026
@ksy36 ksy36 force-pushed the triage_statuses branch from db32b1a to 79d7c66 Compare May 7, 2026 16:50
</script>

<style scoped>
.triage-bucket-dropdown {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker for this PR, but I'm not a massive fan of us having all this CSS specific to one dropdown. As we accumulate more components we're just adding lots of CSS for each one and it might be better to try to refactor a bit.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I can probably just use bootstrap's dropdown since we're already including it:) I'll change it in a separate PR

Comment thread tests/e2e/fixtures/fixtures.json Outdated
Comment thread server/frontend/src/components/Buckets/View.vue Outdated
Comment thread tests/e2e/test_bucket_view.py Outdated
Comment thread tests/e2e/test_bucket_view.py Outdated
@ksy36 ksy36 force-pushed the triage_statuses branch from f460344 to 8627de2 Compare May 8, 2026 21:07
@ksy36 ksy36 force-pushed the triage_statuses branch 2 times, most recently from 8b3643c to d84c22d Compare May 9, 2026 04:18
@ksy36 ksy36 force-pushed the triage_statuses branch from 8e4a4e2 to b55c688 Compare May 11, 2026 02:25
}

function fetch_api_data() {
fetch(notify_api_url+'?max='+notify_fetch_count, {credentials: 'same-origin'})

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed this request if failing on every page since we're no longer using notifications, so removing it

@ksy36 ksy36 requested a review from jgraham May 11, 2026 03:09
@ksy36 ksy36 merged commit fa4a078 into main May 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants