Skip to content

Commit 4e7d5dd

Browse files
committed
feat: add stage to ignore supplied prefs
1 parent 4bfc291 commit 4e7d5dd

1 file changed

Lines changed: 14 additions & 11 deletions

File tree

src/bugmon/evaluator_configs/browser.py

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ def __init__(self, build_flags: BuildFlags, evaluator: BrowserEvaluator):
3939
super().__init__(build_flags, evaluator)
4040
self.params["entry_point"] = evaluator.testcase
4141
self.params["use_harness"] = evaluator.use_harness
42+
self.params["use_prefs"] = bool(evaluator.prefs)
4243
self.params["env_variables"] = evaluator.env_vars
4344

4445
@classmethod
@@ -93,14 +94,16 @@ def iterate(
9394
continue
9495

9596
for use_harness in [True, False]:
96-
evaluator = BrowserEvaluator(
97-
testcase,
98-
env=env_variables,
99-
display="default" if system() == "Windows" else "xvfb",
100-
prefs=prefs,
101-
repeat=10,
102-
relaunch=1,
103-
use_harness=use_harness,
104-
)
105-
106-
yield cls(build_flags, evaluator)
97+
# Don't always use prefs if they exist as they might be invalid
98+
for pref_path in [prefs, None] if prefs is not None else [None]:
99+
evaluator = BrowserEvaluator(
100+
testcase,
101+
env=env_variables,
102+
display="default" if system() == "Windows" else "xvfb",
103+
prefs=pref_path,
104+
repeat=10,
105+
relaunch=1,
106+
use_harness=use_harness,
107+
)
108+
109+
yield cls(build_flags, evaluator)

0 commit comments

Comments
 (0)