PR-i18n-2b: DE translations for 183/183 catalog keys + test fixes#21
Merged
Conversation
The DE locale catalog landed empty in PR-i18n-2a (mechanical wrap only). Production at filemorph.io/de/ rendered English everywhere because gettext falls back to msgid when msgstr is empty. This PR translates all 183 keys to German with a technical, terse tone matching the existing DE templates (impressum, original-DE enterprise) and the CLAUDE.md "Technology First" motto — no marketing-speak, direct addressing (du-form), German number formatting (10.000 not 10,000; 0,05 not 0.05), German tech-term conventions (Konvertieren, Komprimieren, Tarife, Preise, Datenschutzerklärung, Nutzungsbedingungen). Brand names stay English (FileMorph, Pro, Business, Enterprise, Compliance Edition, GitHub, Stripe). Format/extension lists (HEIC, JPG, MP4 etc.) stay verbatim. Boilerplate that's a brand feature stays untranslated (GitHub Security Advisories, Safe-Harbour, AGPLv3 Open Source). Test fixes — 6 tests asserted English-only strings on the unprefixed default route, which now renders DE. Updated to hit /en/<path> explicitly when the assertion checks an English copy marker: - test_verify_email_page_renders → /en/verify-email - test_each_tier_lists_quota_concurrent_and_rate (pricing_html fixture) → /en/pricing (DE uses 10.000/100.000 + "gleichzeitig") - test_public_legal_page_reachable[/security-...] → /en/security (DE renders "Eine Sicherheitslücke melden") - test_pricing_renders_coming_soon_when_stripe_disabled → /en/pricing (DE renders "demnächst verfügbar") 462 passed, 12 skipped, 0 failed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DE locale catalog landed empty in PR-i18n-2a (mechanical wrap only). Production at filemorph.io/de/ rendered English everywhere because gettext falls back to msgid when msgstr is empty.
This PR translates all 183 keys to German with a technical, terse tone matching the existing DE templates (impressum, original-DE enterprise) and the CLAUDE.md "Technology First" motto — no marketing-speak, direct addressing (du-form), German number formatting (10.000 not 10,000; 0,05 not 0.05), German tech-term conventions (Konvertieren, Komprimieren, Tarife, Preise, Datenschutzerklärung, Nutzungsbedingungen).
Brand names stay English (FileMorph, Pro, Business, Enterprise, Compliance Edition, GitHub, Stripe). Format/extension lists (HEIC, JPG, MP4 etc.) stay verbatim. Boilerplate that's a brand feature stays untranslated (GitHub Security Advisories, Safe-Harbour, AGPLv3 Open Source).
Test fixes — 6 tests asserted English-only strings on the unprefixed default route, which now renders DE. Updated to hit /en/ explicitly when the assertion checks an English copy marker:
462 passed, 12 skipped, 0 failed.