Skip to content

Commit 6b3c9f9

Browse files
Jitse BoonstraMrMicky-FR
authored andcommitted
Some minor updates to FastInv (#2)
* Added final keyword to effectively final objects. * Added "this" keyword to object declaration.
1 parent 43905d1 commit 6b3c9f9

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/main/java/fr/mrmicky/fastinv/FastInv.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,13 +28,13 @@
2828
*/
2929
public class FastInv implements InventoryHolder {
3030

31-
private Predicate<Player> closeFilter;
31+
private final Map<Integer, Consumer<InventoryClickEvent>> itemHandlers = new HashMap<>();
3232

3333
private Set<Consumer<InventoryOpenEvent>> openHandlers;
3434
private Set<Consumer<InventoryCloseEvent>> closeHandlers;
3535
private Set<Consumer<InventoryClickEvent>> clickHandlers;
36-
private Map<Integer, Consumer<InventoryClickEvent>> itemHandlers = new HashMap<>();
3736

37+
private Predicate<Player> closeFilter;
3838
private Inventory inventory;
3939

4040
/**

src/main/java/fr/mrmicky/fastinv/ItemBuilder.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,16 +21,16 @@
2121
*/
2222
public class ItemBuilder {
2323

24-
private ItemStack item;
25-
private ItemMeta meta;
24+
private final ItemStack item;
25+
private final ItemMeta meta;
2626

2727
public ItemBuilder(Material material) {
2828
this(new ItemStack(material));
2929
}
3030

3131
public ItemBuilder(ItemStack item) {
3232
this.item = Objects.requireNonNull(item, "item");
33-
meta = item.getItemMeta();
33+
this.meta = item.getItemMeta();
3434
}
3535

3636
public ItemBuilder type(Material material) {
@@ -107,7 +107,7 @@ public ItemBuilder addLore(String line) {
107107
List<String> lore = meta.getLore();
108108

109109
if (lore == null) {
110-
return lore(Collections.singletonList(line));
110+
return lore(line);
111111
}
112112

113113
lore.add(line);

0 commit comments

Comments
 (0)