GT 16 bits image support + lossless 16bits cache for HDR training [VOLINGA]#1335
Merged
Conversation
Owner
|
Thank you. I will review it carefully. There is nvimagecodec as dependency in this repo and it supports JPEG2000. However, I have stripped down the repo aggressively so I need to tests if that's still working. |
Owner
|
I have tested it. In general it works but the reconstruction is very poor. Do you have any images you can share where it outperforms the standard training path. |
Contributor
Author
Owner
|
@AlbertoValenzuelaRedondo Ok, thank you. I will merge this shortly and try to fix the jpeg so that it works based on the external dependency that is shipped. I will also switch the flag so it will be enabled with an explicit flag something like --use-16bit Maybe I will ping you later for a dataset if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This set of commits introduces support for 16-bit and FP32 image workflows, making the image pipeline more flexible and better prepared for HDR and high-precision image inputs.
The loading path has been improved to support u16 and FP32 images, with internal templating added to load_image_t to make the implementation cleaner and easier to extend. A new CUDA kernel was also added to convert FP32 images from HWC to CHW layout directly on the GPU.
JPEG2000 support has been added for lossless encoding, with the correct encoding selected depending on the active configuration. The decoding path has also been advanced, including work on 16-bit decoding and support for float tensors during Lanczos resize.
A new --use_8bit_color flag has been introduced to easily switch between standard 8-bit input and HDR 16-bit image input by disabling it with 0.
To build and compile these changes correctly, JPEG2000 development support needs to be installed on the target machine, including the required libraries and headers.
We merged this based on an old commit, please doble check that we are not breaking any new functionality added in between.