Skip to content

windows: fix test linking#998

Merged
MrNeRF merged 1 commit into
MrNeRF:masterfrom
miriameng:windows_test
Mar 17, 2026
Merged

windows: fix test linking#998
MrNeRF merged 1 commit into
MrNeRF:masterfrom
miriameng:windows_test

Conversation

@miriameng

Copy link
Copy Markdown
Collaborator

Fix

    test_undo_history.obj : error LNK2019: unresolved external symbol "public: __cdecl
     lfs::vis::op::TensorUndoEntry::TensorUndoEntry(...)"
    test_undo_history.obj : error LNK2019: unresolved external symbol "public: void __cdecl
     lfs::vis::op::TensorUndoEntry::captureAfter(void)"
    test_undo_history.obj : error LNK2019: unresolved external symbol "public: __cdecl
     lfs::vis::op::CropBoxUndoEntry::CropBoxUndoEntry(...)"
    test_undo_history.obj : error LNK2019: unresolved external symbol "public: __cdecl
     lfs::vis::op::EllipsoidUndoEntry::EllipsoidUndoEntry(...)"
    test_undo_history.obj : error LNK2019: unresolved external symbol "public: __cdecl
     lfs::vis::op::PropertyChangeUndoEntry::PropertyChangeUndoEntry(...)"
   
    C:\...\lichtfeld_tests.exe : fatal error LNK1120: 12 unresolved externals

@miriameng miriameng requested a review from MrNeRF March 17, 2026 06:53
@MrNeRF

MrNeRF commented Mar 17, 2026

Copy link
Copy Markdown
Owner

Weird that it pops up for you. The nightly Windows build is ok!

@MrNeRF MrNeRF merged commit c631748 into MrNeRF:master Mar 17, 2026
5 checks passed
@miriameng miriameng deleted the windows_test branch March 17, 2026 15:17
@miriameng

miriameng commented Mar 17, 2026

Copy link
Copy Markdown
Collaborator Author

If we can figure out a way to compile unit tests in CI we will see the same error

Aka #685

@MrNeRF

MrNeRF commented Mar 17, 2026

Copy link
Copy Markdown
Owner

Yeah, I still don't have an infrastructure sponsor. Hopefully soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants