Skip to content

Commit 4a6173e

Browse files
Merge pull request #2 from MutsiMutsi/fix/redundant-task-await
Fix/redundant task await
2 parents f457b77 + 209937e commit 4a6173e

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

Add Identity To Content/ImageProcessor.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ public static async Task ProcessGifsAsync(List<DroppedObject> gifFiles, string w
169169
/// <param name="mp4FilePath"></param>
170170
/// <returns></returns>
171171
/// <exception cref="InvalidOperationException"></exception>
172-
private static async Task ConvertGifToMp4Async(string gifFilePath, string mp4FilePath)
172+
private static Task ConvertGifToMp4Async(string gifFilePath, string mp4FilePath)
173173
{
174174
// Inform the user the conversion is starting
175175
Console.WriteLine("Starting conversion of GIF to MP4...");
@@ -178,7 +178,7 @@ private static async Task ConvertGifToMp4Async(string gifFilePath, string mp4Fil
178178
Console.WriteLine("Please be patient, the conversion will finish, even if the progress bar is not at 100%.");
179179

180180
// Start the FFmpeg process to convert the GIF to MP4
181-
await Task.Run(() =>
181+
return Task.Run(() =>
182182
{
183183
// set foreground colour to green
184184
Console.ForegroundColor = ConsoleColor.Green;
@@ -324,10 +324,10 @@ public static async Task ProcessVideosAsync(List<DroppedObject> videoFiles, stri
324324
/// <param name="totalFiles">The total number of video files to be processed.</param>
325325
/// <returns>A task that represents the asynchronous operation.</returns>
326326
/// <exception cref="InvalidOperationException">Thrown when the FFmpeg process fails.</exception>
327-
private static async Task AddWatermarkToVideoAsync(string inputFilePath, string watermarkPath, string outputFilePath, int currentIndex, int totalFiles)
327+
private static Task AddWatermarkToVideoAsync(string inputFilePath, string watermarkPath, string outputFilePath, int currentIndex, int totalFiles)
328328
{
329329
// Start the FFmpeg process to add the watermark to the video
330-
await Task.Run(() =>
330+
return Task.Run(() =>
331331
{
332332
// Set the console text color to yellow
333333
Console.ForegroundColor = ConsoleColor.Yellow;

0 commit comments

Comments
 (0)