Skip to content

Commit a022a97

Browse files
update
1 parent cc90706 commit a022a97

5 files changed

Lines changed: 21 additions & 24 deletions

File tree

packages/react/src/components/DiffViewWithMultiSelect.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,9 @@ const InternalDiffViewWithMultiSelect = <T extends unknown>(
130130
} else {
131131
containerRef.current?.classList.remove(multiSelectClassNames.selecting);
132132
}
133+
if (state.isSelecting && multiResultRef.current) {
134+
updateMultiResult(undefined);
135+
}
133136
memoSelectChange?.(range, state);
134137
},
135138
onSelectionComplete: (result) => {

packages/solid/index.d.ts

Lines changed: 9 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1087,24 +1087,6 @@ export type DiffViewProps_2<T> = Omit<DiffViewProps<T>, "data"> & {
10871087
declare function SolidDiffView<T>(props: DiffViewProps_1<T>): JSXElement;
10881088
declare function SolidDiffView<T>(props: DiffViewProps_2<T>): JSXElement;
10891089
export declare const DiffView: typeof SolidDiffView;
1090-
/**
1091-
* Extended data item with fromLine support for multi-line comments
1092-
*/
1093-
export interface MultiSelectExtendDataItem<T = unknown> {
1094-
data: T;
1095-
/**
1096-
* Starting line number for multi-line selection
1097-
* If not provided, defaults to the key (end line number)
1098-
*/
1099-
fromLine?: number;
1100-
}
1101-
/**
1102-
* Extended data format for multi-select diff view
1103-
*/
1104-
export type MultiSelectExtendData<T = unknown> = {
1105-
oldFile?: Record<string, MultiSelectExtendDataItem<T>>;
1106-
newFile?: Record<string, MultiSelectExtendDataItem<T>>;
1107-
};
11081090
export type DiffViewWithMultiSelectProps<T> = {
11091091
data?: {
11101092
oldFile?: {
@@ -1119,10 +1101,14 @@ export type DiffViewWithMultiSelectProps<T> = {
11191101
};
11201102
hunks: string[];
11211103
};
1122-
/**
1123-
* Extended data with fromLine support for multi-line comments
1124-
*/
1125-
extendData?: MultiSelectExtendData<T>;
1104+
extendData?: {
1105+
oldFile?: Record<string, {
1106+
data: T;
1107+
}>;
1108+
newFile?: Record<string, {
1109+
data: T;
1110+
}>;
1111+
};
11261112
initialWidgetState?: {
11271113
side: SplitSide;
11281114
lineNumber: number;
@@ -1166,9 +1152,8 @@ export type DiffViewWithMultiSelectProps<T> = {
11661152
diffFile: DiffFile;
11671153
onClose: () => void;
11681154
}) => JSXElement;
1169-
renderExtendLine?: ({ diffFile, side, data, lineNumber, fromLineNumber, onUpdate, }: {
1155+
renderExtendLine?: ({ diffFile, side, data, lineNumber, onUpdate, }: {
11701156
lineNumber: number;
1171-
fromLineNumber: number;
11721157
side: SplitSide;
11731158
data: T;
11741159
diffFile: DiffFile;

packages/solid/src/components/DiffViewWithMultiSelect.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,9 @@ const InternalDiffViewWithMultiSelect = <T extends unknown>(props: DiffViewWithM
138138
} else {
139139
containerRef()?.classList.remove(multiSelectClassNames.selecting);
140140
}
141+
if (state.isSelecting && multiResultRef) {
142+
updateMultiResult(undefined);
143+
}
141144
props.onMultiSelectChange?.(range, state);
142145
},
143146
onSelectionComplete: (result) => {

packages/svelte/src/lib/components/DiffViewWithMultiSelect.svelte

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,9 @@
134134
} else {
135135
containerRef?.classList.remove(multiSelectClassNames.selecting);
136136
}
137+
if (state.isSelecting && multiResultRef) {
138+
updateMultiResult(undefined);
139+
}
137140
props.onMultiSelectChange?.(range, state);
138141
},
139142
onSelectionComplete: (result) => {

packages/vue/src/components/DiffViewWithMultiSelect.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,9 @@ export const DiffViewWithMultiSelect = defineComponent<
9494
} else {
9595
containerRef.value?.classList.remove(multiSelectClassNames.selecting);
9696
}
97+
if (state.isSelecting && multiResultRef) {
98+
updateMultiResult(undefined);
99+
}
97100
options.emit("onMultiSelectChange", range, state);
98101
},
99102
onSelectionComplete: (result) => {

0 commit comments

Comments
 (0)