Address AI comments

Author: brownd1978

KinKalGeom/inc/CRV.hh

@@ -17,16 +17,13 @@ namespace mu2e {
     };
     class CRV {
       public:
-        // default constructor (empty)
-        CRV();
         // construct with rectangles representing the midplane of CRV sectors (shields)
         CRV(std::vector<KKCRVSector> const& sectors) : sectors_(sectors) {}
         // accessors
         auto const& sectors() const { return sectors_; }
         auto const& sector(size_t isect) const { return sectors_[isect].sector_; }
         auto const& sectorName(size_t isect) const { return sectors_[isect].sname_; }
         auto const& sectorHalfWidth(size_t isect) const { return sectors_[isect].whw_; }
-
       private:
         std::vector<KKCRVSector> sectors_;
     };

Mu2eKinKal/inc/ExtrapolateCRV.hh

@@ -76,7 +76,7 @@ namespace mu2e {
     auto stime = tdir == TimeDir::forwards ? ktraj.range().begin()+epsilon : ktraj.range().end()-epsilon;
     auto etime = tdir == TimeDir::forwards ? ktraj.range().end() : ktraj.range().begin();
     TimeRange trange(stime,etime,false);
-    // test from the start of the end poiece
+    // test from the start of the end piece
     auto pos = ktraj.position3(stime);
     auto vel = ktraj.velocity(stime);
     if(debug_ > 4)std::cout << "CRV extrap tdir " << tdir << " stime " << stime << " etime " << etime << " vel " << vel << " pos " << pos << std::endl;
@@ -94,9 +94,9 @@ namespace mu2e {
         inters_.emplace_back(newinter,sector.whw_,(int)isect);
         if(debug_ > 1)std::cout << "Good CRV " <<  newinter << " sector " << sector.sname_ << std::endl;
       } else if ( newinter.onsurface_ && newinter.inbounds_) { // inbounds might be too strict for CentralHelix tracks, will need to check TODO
-        retval = trange.beyond(newinter.time_,tdir);
+        retval |= trange.beyond(newinter.time_,tdir);
         // there's a potential intersection, but the trajectory hasn't gotten there yet. Tell the track to keep extending
-        if(retval && debug_ > 2)std::cout << "Potential CRV " <<  newinter << std::endl;
+        if(trange.beyond(newinter.time_,tdir) && debug_ > 2)std::cout << "Potential CRV " <<  newinter << std::endl;
       }
     }
     // sort intersections in the time direction

Mu2eKinKal/inc/KKFitSettings.hh

@@ -116,7 +116,7 @@ namespace mu2e {
       fhicl::Atom<float> interTol { Name("IntersectionTolerance"), Comment("Tolerance for surface intersections (mm)") };
       fhicl::Atom<float> MaxDt { Name("MaxDt"), Comment("Maximum time to extrapolate a fit (ns)") };
       fhicl::Atom<float> MaxDtStep { Name("MaxDtStep"), Comment("Maximum time step when extrapolating a fit (ns)") };
-      fhicl::Atom<float> MinV { Name("MinV"), Comment("Minimum Y vel to extrapolate a fit") };
+      fhicl::Atom<float> MinV { Name("MinV"), Comment("Minimum velocity perp to the surface extrapolate a straight track fit") };
       fhicl::Atom<bool> BackToTracker { Name("BackToTracker"), Comment("Extrapolate reflecting tracks back to the tracker") };
       fhicl::Atom<bool> ToTrackerEnds { Name("ToTrackerEnds"), Comment("Extrapolate tracks to the tracker ends") };
       fhicl::Atom<bool> Upstream { Name("Upstream"), Comment("Extrapolate tracks upstream") };