Rrivera/dma fix5#55
Merged
Merged
Conversation
…d small and big and very big emulated ROCs
There was a problem hiding this comment.
Pull request overview
Updates the Mu2e SubEvent receiver generator to fetch already-assembled DTC_Event objects from the DTC interface (instead of manually building events from DTC_SubEvent payloads), aiming to improve robustness across a range of emulated ROC event sizes and buffer test modes.
Changes:
- Added
getNextDTCEventFragmentwhich callstheInterface_->GetSubEventDataAsEvents(...)and converts returned events intoDTCEVTfragments. - Switched
getNext_to use the new event-based path (leaving the old subevent-based implementation in place).
| auto block = subevt->GetDataBlock(bl); | ||
| auto first = block->GetHeader(); | ||
| std::string nn = "Packets per ROC " + std::to_string(bl); | ||
| metricMan->sendMetric(nn, first->GetPacketCount(), "Packages", 3, artdaq::MetricMode::Average); |
Comment on lines
+524
to
+531
|
|
||
| double hw_timestamp_rate = 1 / hwTime; | ||
| double hw_data_rate = frags.back()->sizeBytes() / hwTime; | ||
|
|
||
| metricMan->sendMetric("DTC Read Time", artdaq::TimeUtils::GetElapsedTime(after_read, after_copy), "s", 3, artdaq::MetricMode::Average); | ||
| metricMan->sendMetric("Fragment Prep Time", artdaq::TimeUtils::GetElapsedTime(before_read, after_read), "s", 3, artdaq::MetricMode::Average); | ||
| metricMan->sendMetric("HW Timestamp Rate", hw_timestamp_rate, "timestamps/s", 1, artdaq::MetricMode::Average); | ||
| metricMan->sendMetric("PCIe Transfer Rate", hw_data_rate, "B/s", 1, artdaq::MetricMode::Average); |
Comment on lines
+525
to
+526
| double hw_timestamp_rate = 1 / hwTime; | ||
| double hw_data_rate = frags.back()->sizeBytes() / hwTime; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works with small, big, and very big emulated ROC events. Works with Calo ROC in buffer test mode. Simon reports instability using Board Reader.