Rrivera/rtf sync status control improvements#315
Open
rrivera747 wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves visibility and control of the CFO↔RTF timing interface in the Mu2e DTC front-end by adding a dedicated status macro, extending CFO interface setup with an IDELAY tap control, and ensuring soft resets clear relevant CFO/JA error counters.
Changes:
- Add a new FE macro (“Get RTF Interface Status”) and supporting formatter to report CFO/RTF settings, sticky error flags, and RTF histogram/IDELAY readback.
- Extend “CFO Interface (Emulation) Setup” with an optional IDELAY tap value parameter and implement the associated register programming sequence.
- Make
CFOandDTCCoreVInterface::SoftResetvirtual and override it inDTCFrontEndInterfaceto clear additional CFO/JA-related counters after reset.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| otsdaq-mu2e/FEInterfaces/DTCFrontEndInterfaceImpl.cc | Adds status reporting, IDELAY tap programming, DTCCounters output adjustments, and a DTC-specific SoftReset that clears additional counters. |
| otsdaq-mu2e/FEInterfaces/DTCFrontEndInterface.h | Declares new status macro/helper, overrides SoftReset, and extends SetupCFOInterface signature with IDELAY tap argument. |
| otsdaq-mu2e/CFOandDTCCore/CFOandDTCCoreVInterface.h | Makes SoftReset virtual to support polymorphic dispatch to derived overrides. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
corrodis
approved these changes
Jul 18, 2026
corrodis
requested changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.