Skip to content

Rrivera/rtf sync status control improvements#315

Open
rrivera747 wants to merge 5 commits into
developfrom
rrivera/rtfSyncStatusControlImprovements
Open

Rrivera/rtf sync status control improvements#315
rrivera747 wants to merge 5 commits into
developfrom
rrivera/rtfSyncStatusControlImprovements

Conversation

@rrivera747

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves visibility and control of the CFO↔RTF timing interface in the Mu2e DTC front-end by adding a dedicated status macro, extending CFO interface setup with an IDELAY tap control, and ensuring soft resets clear relevant CFO/JA error counters.

Changes:

  • Add a new FE macro (“Get RTF Interface Status”) and supporting formatter to report CFO/RTF settings, sticky error flags, and RTF histogram/IDELAY readback.
  • Extend “CFO Interface (Emulation) Setup” with an optional IDELAY tap value parameter and implement the associated register programming sequence.
  • Make CFOandDTCCoreVInterface::SoftReset virtual and override it in DTCFrontEndInterface to clear additional CFO/JA-related counters after reset.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
otsdaq-mu2e/FEInterfaces/DTCFrontEndInterfaceImpl.cc Adds status reporting, IDELAY tap programming, DTCCounters output adjustments, and a DTC-specific SoftReset that clears additional counters.
otsdaq-mu2e/FEInterfaces/DTCFrontEndInterface.h Declares new status macro/helper, overrides SoftReset, and extends SetupCFOInterface signature with IDELAY tap argument.
otsdaq-mu2e/CFOandDTCCore/CFOandDTCCoreVInterface.h Makes SoftReset virtual to support polymorphic dispatch to derived overrides.

Comment thread otsdaq-mu2e/FEInterfaces/DTCFrontEndInterfaceImpl.cc Outdated
Comment thread otsdaq-mu2e/FEInterfaces/DTCFrontEndInterfaceImpl.cc Outdated
Comment thread otsdaq-mu2e/FEInterfaces/DTCFrontEndInterfaceImpl.cc
rrivera747 and others added 2 commits July 11, 2026 15:48
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@corrodis corrodis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one doesn't compile for me?

In DTCFrontEndInterfaceImpl.cc

  • measuredPos is used but never declared; looks like it got dropped in a91a1fc?
  • The o << " CFO Emulation Mode..." line is missing its terminating; looks like it got truncated in c48d4ed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants