fix: 多线程并行导出谱面的相关问题 (#55)

* fix: missing new MuNET-UI in vcs.xml

* fix: 多线程批量导出谱面时，并发未加锁调用ACB_Load引起的问题

* fix: 批量导出谱面时，wav文件生成后不会被自动删除造成内存爆炸的问题
我批量导出1000多个谱面，导出到一半，C:\Users\username\AppData\Local\Temp\MaiChartManager就占用了近20G磁盘，把我C盘吃满导出失败了。

* 给ConvertToMai里的ACB_File.Load也加上锁

* [F] 导出时改为使用Audio.AcbToWav实时在内存中创建WAV，同时修改ConvertWavPathToMp3Stream为直接接受wav的字节。

Author: Starrah

.idea/.idea.Sitreamai/.idea/vcs.xml

@@ -656,15 +656,15 @@ public async Task ExportAsMaidata(int id, string assetDir, bool ignoreVideo = fa
             Comment = version?.GenreName,
             AlbumArt = img,
         };
-        var wavPath = await AudioConvert.GetCachedWavPath(GetAudioCandidateIds(music));
-        if (wavPath is null)
+        
+        if (!AudioConvert.TryResolveAcbAwb(GetAudioCandidateIds(music), out _, out var acbPath, out var awbPath) || acbPath is null || awbPath is null)
         {
             var message = BuildAudioResolveErrorMessage(music);
             logger.LogError("{message}", message);
             throw new FileNotFoundException(message);
         }
-
-        AudioConvert.ConvertWavPathToMp3Stream(wavPath, soundStream, tag);
+        var wav = Audio.AcbToWav(acbPath);
+        AudioConvert.ConvertWavToMp3Stream(wav, soundStream, tag);
         soundStream.Close();
 
         if (!ignoreVideo && StaticSettings.MovieDataMap.TryGetValue(music.NonDxId, out var movieUsmPath))

MaiChartManager/Controllers/Music/MusicTransferController.cs

@@ -11,7 +11,11 @@ public static class Audio
 {
     public static void ConvertToMai(string srcPath, string savePath, float padding = 0, Stream? src = null, string? previewFilename = null, Stream? preview = null, bool forceUseNAudio = false)
     {
-        var wrapper = new ACB_Wrapper(ACB_File.Load(File.ReadAllBytes(Path.Combine(StaticSettings.exeDir, previewFilename is null ? "nopreview.acb" : "template.acb")), null));
+        ACB_File acbTemplate;
+        lock (_acbFileLoadLock) {
+            acbTemplate = ACB_File.Load(File.ReadAllBytes(Path.Combine(StaticSettings.exeDir, previewFilename is null ? "nopreview.acb" : "template.acb")), null);
+        }
+        var wrapper = new ACB_Wrapper(acbTemplate);
         var trackBytes = LoadAndConvertFile(srcPath, FileType.Hca, false, 9170825592834449000, padding, src, forceUseNAudio);
 
         wrapper.Cues[0].AddTrackToCue(trackBytes, true, false, EncodeType.HCA);
@@ -172,10 +176,15 @@ private static FileType GetFileType(EncodeType encodeType)
                 return FileType.NotSet;
         }
     }
+    
+    private static readonly object _acbFileLoadLock = new();
 
     public static byte[] AcbToWav(string acbPath)
     {
-        var acb = ACB_File.Load(acbPath);
+        ACB_File acb;
+        lock (_acbFileLoadLock) {
+            acb = ACB_File.Load(acbPath);
+        }
         var wave = acb.GetWaveformsFromCue(acb.Cues[0])[0];
         var entry = acb.GetAfs2Entry(wave.AwbId);
         using MemoryStream stream = new MemoryStream(entry.bytes);

MaiChartManager/Utils/Audio.cs

@@ -73,23 +73,26 @@ public static async Task<string> GetCachedWavPath(string acbPath, string awbPath
         return cachePath;
     }
 
-    public static void ConvertWavPathToMp3Stream(string wavPath, Stream mp3Stream, ID3TagData? tagData = null)
+    public static void ConvertWavToMp3Stream(byte[] wav, Stream mp3Stream, ID3TagData? tagData = null)
     {
-        var outputPath = Path.Combine(StaticSettings.tempPath, $"ConvertToMp3_{Guid.NewGuid():N}.mp3");
+        var tempFileGuid = Guid.NewGuid();
+        var inputPath = Path.Combine(StaticSettings.tempPath, $"ConvertToMp3_{tempFileGuid:N}.wav");
+        var outputPath = Path.Combine(StaticSettings.tempPath, $"ConvertToMp3_{tempFileGuid:N}.mp3");
         string? albumArtPath = null;
         try
         {
             Directory.CreateDirectory(StaticSettings.tempPath);
+            File.WriteAllBytes(inputPath, wav);
 
             var conversion = FFmpeg.Conversions.New()
-                .AddParameter($"-i " + FFmpegHelper.Escape(wavPath));
+                .AddParameter($"-i " + FFmpegHelper.Escape(inputPath));
 
             if (tagData != null)
             {
                 if (tagData.AlbumArt != null && tagData.AlbumArt.Length > 0)
                 {
                     // 把专辑封面写到临时文件，然后让ffmpeg把它嵌入mp3
-                    albumArtPath = Path.Combine(StaticSettings.tempPath, $"ConvertToMp3_{Guid.NewGuid():N}.png");
+                    albumArtPath = Path.Combine(StaticSettings.tempPath, $"ConvertToMp3_{tempFileGuid:N}.png");
                     File.WriteAllBytes(albumArtPath, tagData.AlbumArt);
                     conversion.AddParameter($"-i {FFmpegHelper.Escape(albumArtPath)}");
                 } // 顺序不能换！这个必须在第一个，因为-i必须在任何其他参数之前。
@@ -122,6 +125,7 @@ public static void ConvertWavPathToMp3Stream(string wavPath, Stream mp3Stream, I
         }
         finally
         {
+            File.Delete(inputPath);
             File.Delete(outputPath);
             if (albumArtPath != null) File.Delete(albumArtPath);
         }