Skip to content

Parameterizes injectivity scaling factor#126

Merged
jmartfrut merged 2 commits into
mainfrom
optinjectivity
Mar 5, 2026
Merged

Parameterizes injectivity scaling factor#126
jmartfrut merged 2 commits into
mainfrom
optinjectivity

Conversation

@jmartfrut

Copy link
Copy Markdown
Collaborator

Introduces a configurable β parameter to the injectivity-preserving line search. Replaces a hardcoded constant in the InjectivityCheck function, allowing better control and tuning of the scaling factor for injectivity preservation during the line search process.

Introduces a configurable `β` parameter to the injectivity-preserving line search.
Replaces a hardcoded constant in the `InjectivityCheck` function, allowing better control and tuning of the scaling factor for injectivity preservation during the line search process.
The `β` parameter was being assigned a value but was not subsequently used within the `Injectivity_Preserving_LS` method. Removing this assignment cleans up the code by eliminating a redundant operation.
@jmartfrut jmartfrut merged commit 2375501 into main Mar 5, 2026
@github-actions

github-actions Bot commented Mar 5, 2026

Copy link
Copy Markdown

Benchmark Results (Julia v1)

Time benchmarks
main 50f137b... main / 50f137b...
Constitutive models/Visco-elastic Ψ 0.0474 ± 0.0072 ms 0.0471 ± 0.0044 ms 1.01 ± 0.18
Constitutive models/Visco-elastic ∂Ψu 0.0625 ± 0.0018 ms 0.062 ± 0.0017 ms 1.01 ± 0.04
Constitutive models/Visco-elastic ∂Ψuu 0.111 ± 0.014 ms 0.111 ± 0.014 ms 0.999 ± 0.18
Simulations/StaticMechanicalDirichlet 0.134 ± 0.0072 s 0.134 ± 0.0087 s 1 ± 0.085
Simulations/StaticMechanicalNeumann 0.131 ± 0.013 s 0.128 ± 0.012 s 1.02 ± 0.14
Simulations/ViscoElastic 20.9 s 20.5 s 1.02
Tensor algebra/Cofactor 0.07 ± 0 μs 0.07 ± 0 μs 1 ± 0
Tensor algebra/Det(A)Inv(A') 0.13 ± 0.001 μs 0.131 ± 0.01 μs 0.992 ± 0.076
Tensor algebra/δδ_λ_2d 30 ± 0 ns 30 ± 0 ns 1 ± 0
Tensor algebra/δδ_μ_2d 30 ± 0 ns 30 ± 0 ns 1 ± 0
time_to_load 0.0216 ± 0.00012 h 0.0216 ± 5.9e-05 h 1 ± 0.0062
Memory benchmarks
main 50f137b... main / 50f137b...
Constitutive models/Visco-elastic Ψ 1.24 k allocs: 0.0777 MB 1.24 k allocs: 0.0777 MB 1
Constitutive models/Visco-elastic ∂Ψu 1.36 k allocs: 0.0898 MB 1.36 k allocs: 0.0898 MB 1
Constitutive models/Visco-elastic ∂Ψuu 2.32 k allocs: 0.155 MB 2.32 k allocs: 0.155 MB 1
Simulations/StaticMechanicalDirichlet 1.51 M allocs: 0.109 GB 1.51 M allocs: 0.109 GB 1
Simulations/StaticMechanicalNeumann 1.48 M allocs: 0.0933 GB 1.48 M allocs: 0.0933 GB 1
Simulations/ViscoElastic 0.343 G allocs: 22 GB 0.343 G allocs: 22 GB 1
Tensor algebra/Cofactor 1 allocs: 0.0781 kB 1 allocs: 0.0781 kB 1
Tensor algebra/Det(A)Inv(A') 4 allocs: 0.25 kB 4 allocs: 0.25 kB 1
Tensor algebra/δδ_λ_2d 0 allocs: 0 B 0 allocs: 0 B
Tensor algebra/δδ_μ_2d 0 allocs: 0 B 0 allocs: 0 B
time_to_load 0.141 k allocs: 10.8 kB 0.141 k allocs: 10.8 kB 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant