test: cover orchestrator-learning and memory-router#518
Merged
Conversation
Add unit tests for two previously-untested server modules: - orchestrator-learning.ts (1% -> ~96% lines): candidate extraction, dedup/smartUpsert, aging/decay + journal compaction, finding-outcome triage learning, skill model, and decision history. Uses an in-memory OrchestratorMemory and a temp ORCHESTRATOR_DIR. - orchestrator-memory-router.ts (28% -> 100% lines): every memory/trust/ notification route plus auth and 400/empty-monitor edge cases, mounted on an ephemeral Express app. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server/orchestrator-learning.ts: 1% → ~96% lines, 100% funcs (38 tests) — candidate extraction, dedup/smartUpsert, aging/decay + journal compaction, finding-outcome triage learning, the skill model, and decision history. Uses an in-memoryOrchestratorMemoryand a tempORCHESTRATOR_DIR.server/orchestrator-memory-router.ts: 28% → 100% lines, 100% funcs (22 tests) — every memory/trust/notification route plus auth and 400/empty-monitor edge cases, mounted on an ephemeral Express app.No source files or existing tests were modified — only two new test files added. Overall line coverage moves ~58.3% → 60.3%.
Test plan
npx vitest run server/orchestrator-learning.test.ts server/orchestrator-memory-router.test.ts— 60/60 passtsc -bcleaneslintclean on new files🤖 Generated with Claude Code