Skip to content

FOUNDATIONS : Add Candidate#11

Open
imjane5 wants to merge 23 commits into
mainfrom
users/janane/foundations-add-candidate
Open

FOUNDATIONS : Add Candidate#11
imjane5 wants to merge 23 commits into
mainfrom
users/janane/foundations-add-candidate

Conversation

@imjane5

@imjane5 imjane5 commented Jun 8, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread CandidateApp.ConsoleApp/Brokers/Loggings/LoggingBroker.cs
Comment thread CandidateApp.ConsoleApp/Brokers/StorageBrokers/IStorageBroker.Candidate.cs Outdated
Comment thread CandidateApp.ConsoleApp/Brokers/StorageBrokers/StorageBroker.Candidate.cs Outdated
Comment thread CandidateApp.ConsoleApp/Models/Candidates/Exceptions/CandidateServiceException.cs Outdated
{

// given
Candidate invalidCandidate = new Candidate

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var

{
this.storageBrokerMock = new Mock<IStorageBroker>();
this.loggingBrokerMock = new Mock<ILoggingBroker>();
this.candidateService = new CandidateService(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break here

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imjane5 This is still active

@imjane5 imjane5 changed the title FOUNDATIONS : Add Sample FOUNDATIONS : Add Candidate Aug 3, 2022

using System;
using Microsoft.Extensions.Logging;
using System;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure your system directive are placed at the top during code cleanup

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imjane5 This is still open

Comment thread CandidateApp.ConsoleApp/Brokers/StorageBrokers/StorageBroker.Candidate.cs Outdated
Comment thread CandidateApp.ConsoleApp/Models/Candidates/Exceptions/CandidateServiceException.cs Outdated
Times.Once);

this.storageBrokerMock.VerifyNoOtherCalls();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imjane5 This is still open

{
this.storageBrokerMock = new Mock<IStorageBroker>();
this.loggingBrokerMock = new Mock<ILoggingBroker>();
this.candidateService = new CandidateService(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imjane5 This is still active

Comment thread CandidateApp.ConsoleApp/Program.cs Outdated
static void Main(string[] args)
{
Console.WriteLine("Hello World!");
System.Console.WriteLine("Hello World");

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required.

Comment thread CandidateApp.ConsoleApp/Properties/launchSettings.json Outdated

using CandidateApp.ConsoleApp.Models.Candidate;
using CandidateApp.ConsoleApp.Models.Candidates.Exceptions;
using System;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run code cleanup


this.storageBrokerMock.Verify(broker =>
broker.InsertCandidate(It.IsAny<Candidate>()),
Times.Once);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab here

this.loggingBrokerMock.Verify(broker =>
broker.LogError(It.Is(SameExceptionAs(
expectedCandidateValidationException))),
Times.Once);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants