Replaced qdmi calls in ArchitectureFactory with sys-sage ones#17
Open
Durganshu wants to merge 3 commits into
Open
Replaced qdmi calls in ArchitectureFactory with sys-sage ones#17Durganshu wants to merge 3 commits into
Durganshu wants to merge 3 commits into
Conversation
burgholzer
requested changes
Jul 16, 2024
burgholzer
left a comment
burgholzer
left a comment
There was a problem hiding this comment.
Also here: many thanks for preparing this! 🙏
Lot's of the comments are repeated from the FoMaC PR, so do not be surprised.
The naming of these sys-sage functions might need some bike shedding. But the overall functionality looks good 👍🏻
| // create a coupling map | ||
| err = QDMI_query_all_qubits(dev, &qubits); | ||
| // An instance to QunatumBackend for storing the topology | ||
| QuantumBackend* qc = new QuantumBackend(0, "IBM_Backend"); |
There was a problem hiding this comment.
Instead of managing the memory manually here, couldn't the sys-sage query function simply return a QuantumBackend?
That local variable would leave the scope after the function returns and would be collected.
Author
There was a problem hiding this comment.
This is a nice suggestion. Do you mean createQcTopo returns a QuantumBackend object?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion with @burgholzer and @lsschmid, I'm creating this draft PR to evaluate the possibility of using sys-sage for passes and maybe later on for
Architectureclass of QMAP.Feel free to drop your feedback.
P.S.: As of now, I have been testing
sys-sagewith the QDMI'sibm-backend-testingbranch. Subsequently, the implementation proposed here also uses the same branch,