Skip to content

Commit 133b5ac

Browse files
committed
Improve instructions for Wireless Debugging
Signed-off-by: Muntashir Al-Islam <muntashirakon@riseup.net>
1 parent daa54ac commit 133b5ac

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

app/src/main/java/io/github/muntashirakon/AppManager/settings/Ops.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -423,17 +423,18 @@ private static void autoDetectRootSystemOrAdbAndPersist(@NonNull Context context
423423
public static void connectWirelessDebugging(@NonNull FragmentActivity activity,
424424
@NonNull AdbConnectionInterface callback) {
425425
DialogTitleBuilder builder = new DialogTitleBuilder(activity)
426-
.setTitle(R.string.wireless_debugging)
426+
.setTitle(R.string.manual_wireless_debugging_title)
427427
.setEndIcon(R.drawable.ic_open_in_new, v -> {
428428
Intent intent = new Intent(android.provider.Settings.ACTION_APPLICATION_DEVELOPMENT_SETTINGS)
429+
.putExtra(":settings:fragment_args_key", "toggle_adb_wireless")
429430
.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
430431
activity.startActivity(intent);
431432
})
432433
.setEndIconContentDescription(R.string.open_developer_options_page);
433434

434435
new MaterialAlertDialogBuilder(activity)
435436
.setCustomTitle(builder.build())
436-
.setMessage(R.string.choose_what_to_do)
437+
.setMessage(R.string.manual_wireless_debugging_instructions)
437438
.setCancelable(false)
438439
.setPositiveButton(R.string.adb_connect, (dialog1, which1) -> callback.onStatusReceived(STATUS_ADB_CONNECT_REQUIRED))
439440
.setNeutralButton(R.string.adb_pair, (dialog1, which1) -> callback.onStatusReceived(STATUS_ADB_PAIRING_REQUIRED))
@@ -525,7 +526,7 @@ public static void connectAdbInput(@NonNull FragmentActivity activity,
525526
public static void pairAdbInput(@NonNull FragmentActivity activity,
526527
@NonNull AdbConnectionInterface callback) {
527528
new MaterialAlertDialogBuilder(activity)
528-
.setTitle(R.string.wireless_debugging)
529+
.setTitle(R.string.adb_pairing_title)
529530
.setMessage(R.string.adb_pairing_instruction)
530531
.setCancelable(false)
531532
.setNeutralButton(R.string.action_manual, (dialog, which) -> {
@@ -537,6 +538,7 @@ public static void pairAdbInput(@NonNull FragmentActivity activity,
537538
.setNegativeButton(R.string.cancel, (dialog, which) -> callback.onStatusReceived(STATUS_FAILURE))
538539
.setPositiveButton(R.string.go, (dialog, which) -> {
539540
Intent developerOptionsIntent = new Intent(Settings.ACTION_APPLICATION_DEVELOPMENT_SETTINGS)
541+
.putExtra(":settings:fragment_args_key", "toggle_adb_wireless")
540542
.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
541543
Intent adbPairingServiceIntent = new Intent(activity, AdbPairingService.class)
542544
.setAction(AdbPairingService.ACTION_START_PAIRING);

app/src/main/res/values/strings.xml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1466,7 +1466,7 @@
14661466
<string name="status_connecting_via_mode">Connecting via %s</string>
14671467
<string name="status_connected_via_mode">Connected via %s</string>
14681468
<string name="status_not_connected_via_mode">Could not connect via %s</string>
1469-
<string name="adb_pairing_instruction">Please navigate to the developer options to enable wireless debugging and generate a pairing code. Click <b>Manual</b> if you\'ve already opened the developer options.</string>
1469+
<string name="adb_pairing_instruction">Please navigate to the developer options to enable wireless debugging and generate a pairing code. Once a pairing code is generated, enter it in the popup notification to complete pairing.\n\nClick <b>Manual</b> if you\'ve already opened the developer options.</string>
14701470
<string name="adb_pairing_searching_for_port">Searching…</string>
14711471
<string name="adb_pairing_stop_searching">Stop</string>
14721472
<string name="adb_pairing_input_pairing_code">Pairing code</string>
@@ -1554,4 +1554,7 @@
15541554
<string name="selected_items_accessibility_description">Selected %d out of %d items</string>
15551555
<string name="adb_local_server_port">ADB local server port</string>
15561556
<string name="waiting_for_wifi">Waiting for Wi-Fi</string>
1557+
<string name="adb_pairing_title">Pair App Manager using Wi-Fi</string>
1558+
<string name="manual_wireless_debugging_instructions">App Manager was unable to connect automatically using wireless debugging. Click <b>Pair</b> if you haven\'t paired App Manager using Wi-Fi or if the authorization was revoked. Otherwise click <b>Connect</b> to manually enter the port number. You can also use the button at the top to navigate to the wireless debugging setting.</string>
1559+
<string name="manual_wireless_debugging_title">Connect using Wireless Debugging</string>
15571560
</resources>

0 commit comments

Comments
 (0)