Add packages in google.json#42
Open
Blitz517 wants to merge 7 commits into
Open
Conversation
Signed-off-by: blitziak <107147792+Blitz517@users.noreply.github.com>
forgot to add something Signed-off-by: blitziak <107147792+Blitz517@users.noreply.github.com>
MuntashirAkon
requested changes
Sep 28, 2023
MuntashirAkon
left a comment
MuntashirAkon
left a comment
Owner
There was a problem hiding this comment.
You have lots of issues in your list, so I'm not commenting them individually:
- You suggestions are wrong as per our rules. Please read the README sections thoroughly before adding suggestions.
- Description section is for useful information regarding the app and its behaviour, and can use first or third-person in either active or passive voice. It cannot use second person or imperative sentences. It also cannot be used to suggest stuffs to the user as we have a separate section for it.
- The
IDmust be in alphabetical order.
fixed almost(or all) issues and added some packages to google.json Signed-off-by: blitziak <107147792+Blitz517@users.noreply.github.com>
some packages Signed-off-by: blitziak <107147792+Blitz517@users.noreply.github.com>
Added more found packages on pixel phones Signed-off-by: blitziak <107147792+Blitz517@users.noreply.github.com>
MuntashirAkon
requested changes
Oct 2, 2023
MuntashirAkon
left a comment
MuntashirAkon
left a comment
Owner
There was a problem hiding this comment.
I've left a review for you. As usual, the ids aren't in alphabetical order which is required as per instructions. Thanks.
| @@ -1093,7 +1270,6 @@ | |||
| }, | |||
| { | |||
| "id": "com.google.android.setupwizard.a_overlay", | |||
| }, | ||
| { | ||
| "id": "com.google.android.overlay.modules.permissioncontroller.forframework", | ||
| "label": "com.google.android.overlay.modules.permissioncontroller.forframework", |
| }, | ||
| { | ||
| "id": "com.google.android.overlay.modules.permissioncontroller", | ||
| "label": "com.google.android.overlay.modules.permissioncontroller", |
| "label": "com.google.android.overlay.modules.permissioncontroller", | ||
| "description": "Permission controller Theme pack. Guessing it's a pack of themes for the Permission Controller based on the name.", | ||
| "removal": "caution" | ||
| "description": "I only detect on this app: help_app_permissions https://support.google.com/googleplay/answer/6270602\nIt looks very useless.\nNot needed, it doesnt affect on (com.google.android.permissioncontroller)", |
| }, | ||
| { | ||
| "id": "com.google.android.overlay.permissioncontroller", | ||
| "description": "I only detect on this app: help_app_permissions https://support.google.com/googleplay/answer/6270602\nIt looks very useless.\nNot needed, it doesnt affect on (com.google.android.permissioncontroller)", |
| "removal": "delete" | ||
| }, | ||
| { | ||
| "id": "com.google.android.overlay.settingsProvider", |
| }, | ||
| { | ||
| "id": "com.google.android.overlay.gmsconfig", | ||
| "description": "Useless configurations about webview, wifi and bluethooth to scan for better location.\neverything works without it.", |
| { | ||
| "id": "com.google.android.captiveportallogin", | ||
| "label": "CaptivePortalLogin", | ||
| "description": "Its the same as(com.android.captiveportallogin). Support for captive portal.\nA captive portal login is a web page where the users have to input their login information or accept the displayed terms of use. \nSome networks (typically public wifi network) use the captive portal login to block access until the user inputs \nsome necessary information\nNOTE : This package is a now a mandatory mainline module", |
Owner
There was a problem hiding this comment.
Description is in violation with removal. It says mandatory but removal says replaceable.
| }, | ||
| { | ||
| "id": "com.google.audio.hearing.visualization.accessibility.scribe", | ||
| "description": "Live Transcribe & Notification", |
| }, | ||
| { | ||
| "id": "com.google.android.apps.security.securityhub", | ||
| "description": "Security Hub", |
Sorted ID also added label missing, (did everything what suggested and removed duplicated packages) maybe better stay on "replace" for mainline telemetry and adservices because it has something to security. (I know that google problably maded it for more spying but not confirmed by checking code) I think at this point we are done Signed-off-by: blitziak <107147792+Blitz517@users.noreply.github.com>
Moved some apps to AOSP because they are from aosp Signed-off-by: blitziak <107147792+Blitz517@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuation of my lists.