first try for enhanced manage.sh :)

Author: Natenom

scripts/manage.conf

@@ -0,0 +1,5 @@
+# Important: Before you enable an additional bot you must first have created the needed directories,
+# see http://mumble-ruby-pluginbot.readthedocs.io/en/master/installation_howto.html
+# To enable additional bots after that extend the following variable like BOTS_ENABLED="1 2 3 4 5"
+
+BOTS_ENABLED="1"

scripts/manage.sh

@@ -4,6 +4,9 @@
 ### Also make sure that the locale it is activated in /etc/locale.gen
 #export LANG="en_US.UTF-8"
 
+# Read settings for this script
+source $HOME/src/mumble-ruby-pluginbot/scripts/manage.conf
+
 function show_help() {
     cat<<EOF
 USAGE
@@ -20,46 +23,8 @@ OPTIONS
 EOF
 }
 
-function stop_bots_and_mpds() {
-  ### Kill running tmux bot "windows" (of the user botmaster) ###
-  echo "Killing tmux windows used by bots of user $USER"
-  tmux kill-window -t bot1 > /dev/null 2>&1
-  tmux kill-window -t bot2 > /dev/null 2>&1
-  tmux kill-window -t bot3 > /dev/null 2>&1
-  sleep 1
-  tmux kill-window -t bot1 > /dev/null 2>&1
-  tmux kill-window -t bot2 > /dev/null 2>&1
-  tmux kill-window -t bot3 > /dev/null 2>&1
-
-  ### Kill running mumble-ruby-pluginbots (of the user botmaster) ###
-  echo "Killing running ruby scripts of user $USER"
-  killall ruby > /dev/null 2>&1
-  sleep 1
-  killall ruby > /dev/null 2>&1
-
-  ### Kill all running mpd instances (of the user botmaster) ... ###
-  echo "Killing running mpd instances of user $USER"
-  killall mpd > /dev/null 2>&1
-  sleep 2
-  killall mpd > /dev/null 2>&1
-}
-
-function update_youtubedl() {
-  # Do an update of youtube-dl on every start as there are very often updates.
-  if [ -f $HOME/src/youtube-dl ]; then
-      echo "Updating youtube-dl..."
-      $HOME/src/youtube-dl -U
-  fi
-}
-
-function start_mpds() {
-  ### Start needed mpd instances for botmaster ###
-  mpd $HOME/mpd1/mpd.conf
-  #mpd $HOME/mpd2/mpd.conf
-  #mpd $HOME/mpd3/mpd.conf
-}
-
-function start_bots() {
+function start_bot_ruby() {
+  local botid=${1}
   source ~/.rvm/scripts/rvm
   rvm use @bots
 
@@ -68,55 +33,98 @@ function start_bots() {
 
   ### Export enviroment variable for tmux
   export HOME=$HOME
+  tmux new-session -d -s "bot${botid}" "while true; do LD_LIBRARY_PATH=$HOME/src/celt/lib/ ruby $HOME/src/mumble-ruby-pluginbot/core/pluginbot.rb --config=$HOME/src/bot${botid}_conf.yml >> $HOME/logs/bot${botid}.log 2>&1 ; sleep 10; done"
+}
 
-  ### Start Mumble-Ruby-Bots - MPD instances must already be running. ###
-  # Bot 1
-  tmux new-session -d -n bot1 "while true; do LD_LIBRARY_PATH=$HOME/src/celt/lib/ ruby $HOME/src/mumble-ruby-pluginbot/core/pluginbot.rb --config=$HOME/src/bot1_conf.yml >> $HOME/logs/bot1.log 2>&1 ; sleep 10; done"
+function stop_bot_ruby() {
+  local botid=${1}
+  tmux kill-session -t "bot${botid}" > /dev/null 2>&1
+}
 
-  # Bot 2
-  #tmux new-session -d -n bot2 "while true; do LD_LIBRARY_PATH=$HOME/src/celt/lib/ ruby $HOME/src/mumble-ruby-pluginbot/core/pluginbot.rb --config=$HOME/src/bot2_conf.yml >> $HOME/logs/bot2.log 2>&1; sleep 10; done"
+function start_bot_mpd() {
+  local botid=${1}
+  mpd $HOME/mpd${botid}/mpd.conf > /dev/null 2>&1
+}
+function stop_bot_mpd() {
+  local botid=${1}
+  local mpdpid=$(ps aux | grep -i mpd | grep -v grep | grep -E "mpd.*mpd${botid}" | cut -d" " -f2)
+  kill ${mpdpid} > /dev/null 2>&1
+}
 
-  # Bot 3
-  #tmux new-session -d -n bot3 "while true; do LD_LIBRARY_PATH=$HOME/src/celt/lib/ ruby $HOME/src/mumble-ruby-pluginbot/core/pluginbot.rb --config=$HOME/src/bot3_conf.yml >> $HOME/logs/bot3.log 2>&1; sleep 10; done"
+function start_all_bots() {
+  for botid in ${BOTS_ENABLED};
+  do
+    start_bot_ruby ${botid}
+    start_bot_mpd ${botid}
+  done
+}
 
+function stop_all_bots() {
+  for botid in ${BOTS_ENABLED};
+  do
+    stop_bot_ruby ${botid}
+    stop_bot_mpd ${botid}
+  done
 }
 
-function show_disclaimer() {
-  cat <<EOF
+function restart_all_bots() {
+  stop_all_bots
+  start_all_bots
+}
 
+function status_bot() {
+  local botid=${1}
+  local _status=$(tmux list-sessions 2> /dev/null | sed -r -n -e "s/^(bot)${botid}.*/\1/p")
 
+  if [ "${_status}" == "bot" ]; then
+    echo "Bot ${botid} is running"
+  else
+    echo "Bot ${botid} is not running"
+  fi
+}
 
-  Your bot(s) should now be connected to the configured Mumble server.
+function status_all_bots() {
+  for botid in ${BOTS_ENABLED};
+  do
+    status_bot ${botid}
+  done
+}
 
+function update_youtubedl() {
+  # Do an update of youtube-dl on every start as there are very often updates.
+  if [ -f $HOME/src/youtube-dl ]; then
+      echo "Updating youtube-dl..."
+      $HOME/src/youtube-dl -U
+  fi
+}
 
-  _LOGGING/DEBUGGING_
-    If something doesn't work, activate the debug config option in the main configuration file and restart the bot.
+function show_disclaimer() {
+  cat <<EOF
 
-    Then take a look into the logfile within $HOME/logs/.
+  Your bot(s) should now be connected to the configured Mumble server.
 
+  _LOGGING/DEBUGGING_
+    If something doesn't work please read at
+    http://mumble-ruby-pluginbot.rtfd.io/en/master/known_problems.html
 
   _START AS APPROPRIATE USER_
     Make sure to run this script as user botmaster if you used the official
     installation documentation and DO NOT RUN THIS SCRIPT AS root.
     The official documentation can be found at http://mumble-ruby-pluginbot.readthedocs.io/
 
-
   _UPDATE THE BOT (AND ITS DEPENDENCIES)_
     If you want to update the Mumble-Ruby-Pluginbot (and its dependencies) please
     run ~/src/mumble-ruby-pluginbot/scripts/updater.sh
 
-
   _OFFICIAL DOCUMENTATION_
-    Also please reread the official documentation at http://mumble-ruby-pluginbot.readthedocs.io/
-    if you have further problems :)
-
+    Read the official documentation at http://mumble-ruby-pluginbot.readthedocs.io/
 
   _BUGS/WISHES/IDEAS_
     If you think you found a bug, have a wish for the bot or some ideas please don't
     hesitate to create an issue at https://github.com/MusicGenerator/mumble-ruby-pluginbot/issues
 
-
   Have fun with the Mumble-Ruby-Pluginbot :)
+
 EOF
 }
 
@@ -128,18 +136,6 @@ function log() {
   "${TAIL_BIN}" -f -n10 ~/logs/*.log
 }
 
-function status() {
-  local _status=$(tmux list-windows 2> /dev/null | sed -r -e "s/.*(bot)[123].*/\1/g")
-
-  if [ "${_status}" == "bot" ]; then
-    echo "Bots are running"
-    return 0
-  else
-    echo "Bots are not running"
-    return 1
-  fi
-}
-
 function parse() {
   if [ "$#" -le "0" ]; then
     show_help
@@ -148,28 +144,24 @@ function parse() {
   while [ "$#" -gt "0" ]; do
     case ${1} in
        status)
-           status
-           exit $?
+           status_all_bots
+           #exit $?
            shift
            ;;
        start)
            update_youtubedl
-           stop_bots_and_mpds
-           start_mpds
-           start_bots
+           restart_all_bots
            show_disclaimer
            shift
            ;;
        restart)
            update_youtubedl
-           stop_bots_and_mpds
-           start_mpds
-           start_bots
+           restart_all_bots
            show_disclaimer
            shift
            ;;
        stop)
-           stop_bots_and_mpds
+           stop_all_bots
            shift
            ;;
        -h|--help)