Fix Track/Disc numbers for Discogs

Author: MusicMoveArr

MiniMediaMetadataAPI.Application/Helpers/DiscogsHelper.cs

@@ -0,0 +1,59 @@
+using System.Text.RegularExpressions;
+using MiniMediaMetadataAPI.Application.Models.Database.Discogs;
+
+namespace MiniMediaMetadataAPI.Application.Helpers;
+
+public static class DiscogsHelper
+{
+    public static int GetDiscNumber(DiscogsReleaseTrack track)
+    {
+        //let's not process this weird stuff, not sure what it means this "arrow"
+        if (track.Position.Contains('→'))
+        {
+            return 0;
+        }
+        
+        //couldn't Discogs come to just 1 standard... this makes no sense to me
+        string cdRegexPrefix = "^[(]{0,1}(CD|CDR|cd|cdr|CD\\-Rom){0,}[ ]*([0-9]*)";
+        string cdRegexPostfix = "(CD|CDR|cd|cdr|CD\\-Rom){1,}([0-9]*)$";
+        
+        //try postfix first otherwise we grab the Tracknumber by accident
+        var postfixMatch = Regex.Match(track.Position, cdRegexPostfix);
+        if (postfixMatch.Success)
+        {
+            return int.TryParse(postfixMatch.Groups.Values.LastOrDefault()?.Value, out var discNumber) ? discNumber : 0;
+        }
+        
+        var prefixMatch = Regex.Match(track.Position, cdRegexPrefix);
+        if (prefixMatch.Success)
+        {
+            return int.TryParse(prefixMatch.Groups.Values.LastOrDefault()?.Value, out var discNumber) ? discNumber : 0;
+        }
+        return 0;
+    }
+    
+    public static string GetTrackNumber(DiscogsReleaseTrack track)
+    {
+        //let's not process this weird stuff, not sure what it means this "arrow"
+        if (track.Position.Contains('→'))
+        {
+            return string.Empty;
+        }
+        
+        //couldn't Discogs come to just 1 standard... this makes no sense to me
+        //cd/CD/cdr/CDR optional prefix
+        //get optional CD Number
+        //try get tracknumber
+        //try get tracknumber from "xx-yy"
+        //try get tracknumber that has prefix "Track" before it
+        string trackRegexPrefix = "^[(]{0,1}(CD|CDR|cd|cdr|CD\\\\-Rom){0,}[ ]*([0-9A-Z]*)[)]{0,1}[ \\\\-\\\\.\\\\\\/]*([0-9]*)[\\- ]*([0-9]*)(Track[ ]*([0-9]*))*";
+        
+        var prefixMatch = Regex.Match(track.Position, trackRegexPrefix);
+        if (prefixMatch.Success)
+        {
+            return int.TryParse(prefixMatch.Groups.Values.LastOrDefault()?.Value, out var trackNumber) ? trackNumber.ToString() : string.Empty;
+        }
+        
+        return string.Empty;
+    }
+}

MiniMediaMetadataAPI.Application/Services/SearchTrackService.cs

@@ -1,6 +1,9 @@
 using System.Diagnostics;
+using System.Text.RegularExpressions;
 using MiniMediaMetadataAPI.Application.Enums;
+using MiniMediaMetadataAPI.Application.Helpers;
 using MiniMediaMetadataAPI.Application.Models;
+using MiniMediaMetadataAPI.Application.Models.Database.Discogs;
 using MiniMediaMetadataAPI.Application.Models.Entities;
 using MiniMediaMetadataAPI.Application.Repositories;
 
@@ -219,8 +222,8 @@ public async Task<SearchTrackResponse> SearchTrack(
                 Url = string.Empty,
                 Duration = !string.IsNullOrWhiteSpace(track.Duration) ? (TimeSpan.TryParseExact(track.Duration, ["m\\:ss", "h\\:mm\\:ss"], null, out var span) ? span : TimeSpan.Zero) : TimeSpan.Zero,
                 Explicit = track.Title?.Contains("(explicit") == true,
-                DiscNumber = track.Position.Contains("-") ? (int.TryParse(track.Position.Split('-')[0], out int disc) ? disc : 1) : 1,
-                TrackNumber = track.Position.Contains("-") ? (int.TryParse(track.Position.Split('-')[1], out int trackNumber) ? trackNumber.ToString() : track.Position) : track.Position,
+                DiscNumber = DiscogsHelper.GetDiscNumber(track),
+                TrackNumber = DiscogsHelper.GetTrackNumber(track),
                 Label = string.Empty,
                 ISRC = track.Release.Identifiers
                     .Where(id => string.Equals(id.Type, "ISRC"))