Skip to content

protocol: validate relative paths#2515

Closed
hyder365 wants to merge 1 commit into
MusicPlayerDaemon:masterfrom
hyder365:fix-relative-path-validation
Closed

protocol: validate relative paths#2515
hyder365 wants to merge 1 commit into
MusicPlayerDaemon:masterfrom
hyder365:fix-relative-path-validation

Conversation

@hyder365

Copy link
Copy Markdown
Contributor

VerifyRelativePathUTF8() only checked that the path was valid UTF-8. Make it reject absolute paths, empty path components, and . or .. components.

This prevents archive entries and other relative paths from registering traversal-style names.

@MaxKellermann

Copy link
Copy Markdown
Member

This PR contains text that is missing in the commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants