Skip to content

tag: limit ID3 tag size#2516

Closed
hyder365 wants to merge 1 commit into
MusicPlayerDaemon:masterfrom
hyder365:fix-id3-tag-size-limit
Closed

tag: limit ID3 tag size#2516
hyder365 wants to merge 1 commit into
MusicPlayerDaemon:masterfrom
hyder365:fix-id3-tag-size-limit

Conversation

@hyder365

Copy link
Copy Markdown
Contributor

Apply the existing 4 MiB ID3 tag size limit to direct ID3v2 tag loading as well.

This avoids allocating very large buffers from the size declared in the ID3 header before reading the rest of the tag.

@MaxKellermann

Copy link
Copy Markdown
Member

This PR contains text that is missing in the commit message.
This is annoying enough that I will close every PR from you that doesn't even pass the most basic smell test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants