Skip to content

tag: limit ID3 tag size #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hyder365 wants to merge 1 commit into from
+4 −1
Closed

tag: limit ID3 tag size #2516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/tag/Id3Load.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#include <algorithm>

static constexpr size_t ID3V1_SIZE = 128;
static constexpr size_t MAX_ID3_TAG_SIZE = 4 * 1024 * 1024;

[[gnu::pure]]
static inline bool
Expand Down Expand Up @@ -46,6 +47,8 @@ try {
return nullptr;

const std::size_t tag_size = static_cast<std::size_t>(query);
if (tag_size > MAX_ID3_TAG_SIZE)
return nullptr;

/* Found a tag. Allocate a buffer and read it in. */
if (tag_size <= sizeof(query_buffer))
Expand Down Expand Up @@ -185,7 +188,7 @@ try {
if (size == 0)
return nullptr;

if (size > 4 * 1024 * 1024)
if (size > MAX_ID3_TAG_SIZE)
/* too large, don't allocate so much memory */
return nullptr;

Expand Down
Loading