Skip to content

deploy from nightly#63

Merged
MusicalNinjaDad merged 2 commits into
mainfrom
deploy_from_nightly
Apr 11, 2026
Merged

deploy from nightly#63
MusicalNinjaDad merged 2 commits into
mainfrom
deploy_from_nightly

Conversation

@MusicalNinjaDad
Copy link
Copy Markdown
Owner

No description provided.

@MusicalNinjaDad MusicalNinjaDad enabled auto-merge (squash) April 11, 2026 17:17
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Using cargo +nightly publish ties releases to whatever the current nightly is; consider pinning a specific nightly toolchain (e.g. via a rust-toolchain.toml or explicit version) to keep releases reproducible and avoid unexpected breakage when nightly changes.
  • Now that deploy-rust.yml calls rust-stability.yml via workflow_call, double-check that any on: pull_request-specific assumptions (e.g. refs, conditionals) in rust-stability.yml still behave correctly when invoked from another workflow and add any needed guards or defaults.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Using `cargo +nightly publish` ties releases to whatever the current nightly is; consider pinning a specific nightly toolchain (e.g. via a rust-toolchain.toml or explicit version) to keep releases reproducible and avoid unexpected breakage when nightly changes.
- Now that `deploy-rust.yml` calls `rust-stability.yml` via `workflow_call`, double-check that any `on: pull_request`-specific assumptions (e.g. refs, conditionals) in `rust-stability.yml` still behave correctly when invoked from another workflow and add any needed guards or defaults.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@MusicalNinjaDad MusicalNinjaDad merged commit 6131bd7 into main Apr 11, 2026
13 checks passed
@MusicalNinjaDad MusicalNinjaDad deleted the deploy_from_nightly branch April 11, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant