[FEATURE] Represent Selector as Component objects

JakeQZ · JakeQZ · commit 4d287a36709d · 2026-02-09T13:10:30.000Z
Part of #1325.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,9 @@ Please also have a look at our
 
 ### Changed
 
+- `Selector` is now represented as a sequence of `Selector\Component` objects
+  which can be accessed via `getComponents()`, manipulated individually, or set
+  via `setComponents()` (#1478, #1486, #1487, #1488, #1494, #1496)
 - `Selector::setSelector()` and `Selector` constructor will now throw exception
   upon provision of an invalid selectior (#1498, #1502)
 - Clean up extra whitespace in CSS selector (#1398)
diff --git a/src/Property/Selector.php b/src/Property/Selector.php
@@ -11,12 +11,11 @@
 use Sabberworm\CSS\Property\Selector\Combinator;
 use Sabberworm\CSS\Property\Selector\Component;
 use Sabberworm\CSS\Property\Selector\CompoundSelector;
-use Sabberworm\CSS\Property\Selector\SpecificityCalculator;
 use Sabberworm\CSS\Renderable;
+use Sabberworm\CSS\Settings;
 use Sabberworm\CSS\ShortClassNameProvider;
 
 use function Safe\preg_match;
-use function Safe\preg_replace;
 
 /**
  * Class representing a single CSS selector. Selectors have to be split by the comma prior to being passed into this
@@ -59,9 +58,9 @@ class Selector implements Renderable
         /ux';
 
     /**
-     * @var non-empty-string
+     * @var list<Component>
      */
-    private $selector;
+    private $components = [];
 
     /**
      * @internal since V8.8.0
@@ -79,9 +78,13 @@ public static function isValid(string $selector): bool
      *
      * @throws \UnexpectedValueException if the selector is not valid
      */
-    final public function __construct(string $selector)
+    final public function __construct(string $selector = '')
     {
-        $this->setSelector($selector);
+        // Allow construction of empty object for content to be set via `setComponents()`.
+        // (`setSelector()` will throw an exception when provided with an empty string.)
+        if ($selector !== '') {
+            $this->setSelector($selector);
+        }
     }
 
     /**
@@ -144,25 +147,35 @@ public static function parse(ParserState $parserState, array &$comments = []): s
             );
         }
 
-        $selectorString = '';
-        foreach ($selectorParts as $selectorPart) {
-            $selectorPartValue = $selectorPart->getValue();
-            if (\in_array($selectorPartValue, ['>', '+', '~'], true)) {
-                $selectorString .= ' ' . $selectorPartValue . ' ';
-            } else {
-                $selectorString .= $selectorPartValue;
-            }
-        }
+        return (new static())->setComponents($selectorParts);
+    }
 
-        return new static($selectorString);
+    /**
+     * @return list<Component>
+     */
+    public function getComponents(): array
+    {
+        return $this->components;
+    }
+
+    /**
+     * @param list<Component> $components
+     *        This should be an alternating sequence of `CompoundSelector` and `Combinator`, starting and ending with a
+     *        `CompoundSelector`, and may be a single `CompoundSelector`.
+     */
+    public function setComponents(array $components): self
+    {
+        $this->components = $components;
+
+        return $this;
     }
 
     /**
      * @return non-empty-string
      */
     public function getSelector(): string
     {
-        return $this->selector;
+        return $this->render(new OutputFormat());
     }
 
     /**
@@ -172,29 +185,43 @@ public function getSelector(): string
      */
     public function setSelector(string $selector): void
     {
-        if (!self::isValid($selector)) {
-            throw new \UnexpectedValueException("Selector `$selector` is not valid.");
-        }
+        $parserState = new ParserState($selector, Settings::create());
 
-        $selector = \trim($selector);
+        $components = self::parseComponents($parserState);
 
-        $hasAttribute = \strpos($selector, '[') !== false;
+        // Check that the selector has been fully parsed:
+        if (!$parserState->isEnd()) {
+            throw new UnexpectedTokenException(
+                'EOF',
+                $parserState->peek(5),
+                'literal'
+            );
+        }
 
-        // Whitespace can't be adjusted within an attribute selector, as it would change its meaning
-        $this->selector = !$hasAttribute ? preg_replace('/\\s++/', ' ', $selector) : $selector;
+        $this->components = $components;
     }
 
     /**
      * @return int<0, max>
      */
     public function getSpecificity(): int
     {
-        return SpecificityCalculator::calculate($this->selector);
+        return \array_sum(\array_map(
+            static function (Component $component): int {
+                return $component->getSpecificity();
+            },
+            $this->components
+        ));
     }
 
     public function render(OutputFormat $outputFormat): string
     {
-        return $this->getSelector();
+        return \implode('', \array_map(
+            static function (Component $component) use ($outputFormat): string {
+                return $component->render($outputFormat);
+            },
+            $this->components
+        ));
     }
 
     /**
@@ -206,6 +233,12 @@ public function getArrayRepresentation(): array
     {
         return [
             'class' => $this->getShortClassName(),
+            'components' => \array_map(
+                static function (Component $component): array {
+                    return $component->getArrayRepresentation();
+                },
+                $this->components
+            ),
         ];
     }
 }
diff --git a/tests/Unit/Property/KeyframeSelectorTest.php b/tests/Unit/Property/KeyframeSelectorTest.php
@@ -6,6 +6,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Sabberworm\CSS\Property\KeyframeSelector;
+use Sabberworm\CSS\Property\Selector\CompoundSelector;
 
 /**
  * @covers \Sabberworm\CSS\Property\KeyframeSelector
@@ -24,4 +25,16 @@ public function getArrayRepresentationIncludesClassName(): void
 
         self::assertSame('KeyframeSelector', $result['class']);
     }
+
+    /**
+     * @test
+     */
+    public function getArrayRepresentationIncludesComponent(): void
+    {
+        $subject = (new KeyframeSelector())->setComponents([new CompoundSelector('50%')]);
+
+        $result = $subject->getArrayRepresentation();
+
+        self::assertSame('50%', $result['components'][0]['value']);
+    }
 }
diff --git a/tests/Unit/Property/SelectorTest.php b/tests/Unit/Property/SelectorTest.php
@@ -9,6 +9,9 @@
 use Sabberworm\CSS\Parsing\ParserState;
 use Sabberworm\CSS\Parsing\UnexpectedTokenException;
 use Sabberworm\CSS\Property\Selector;
+use Sabberworm\CSS\Property\Selector\Combinator;
+use Sabberworm\CSS\Property\Selector\Component;
+use Sabberworm\CSS\Property\Selector\CompoundSelector;
 use Sabberworm\CSS\Renderable;
 use Sabberworm\CSS\Settings;
 use TRegx\PhpUnit\DataProviders\DataProvider;
@@ -317,10 +320,17 @@ public function parseExtractsTwoCommentsFromSelector(): void
      * @test
      *
      * @dataProvider provideInvalidSelectors
+     * @dataProvider provideInvalidSelectorsForParse
      */
     public function constructorThrowsExceptionWithInvalidSelector(string $selector): void
     {
-        $this->expectException(\UnexpectedValueException::class);
+        // An empty string is allowed to construct an empty object
+        if ($selector === '') {
+            self::expectNotToPerformAssertions();
+            return;
+        }
+
+        $this->expectException(UnexpectedTokenException::class);
 
         new Selector($selector);
     }
@@ -329,16 +339,91 @@ public function constructorThrowsExceptionWithInvalidSelector(string $selector):
      * @test
      *
      * @dataProvider provideInvalidSelectors
+     * @dataProvider provideInvalidSelectorsForParse
      */
     public function setSelectorThrowsExceptionWithInvalidSelector(string $selector): void
     {
-        $this->expectException(\UnexpectedValueException::class);
+        $this->expectException(UnexpectedTokenException::class);
 
         $subject = new Selector('a');
 
         $subject->setSelector($selector);
     }
 
+    /**
+     * @return array<non-empty-string, array{0: list<Component>, 1: list<array{class: string, value: string}>}>
+     */
+    public static function provideComponentsAndArrayRepresentation(): array
+    {
+        return [
+            'simple selector' => [
+                [new CompoundSelector('p')],
+                [
+                    [
+                        'class' => 'CompoundSelector',
+                        'value' => 'p',
+                    ],
+                ],
+            ],
+            'selector with combinator' => [
+                [
+                    new CompoundSelector('ul'),
+                    new Combinator('>'),
+                    new CompoundSelector('li'),
+                ],
+                [
+                    [
+                        'class' => 'CompoundSelector',
+                        'value' => 'ul',
+                    ],
+                    [
+                        'class' => 'Combinator',
+                        'value' => '>',
+                    ],
+                    [
+                        'class' => 'CompoundSelector',
+                        'value' => 'li',
+                    ],
+                ],
+            ],
+        ];
+    }
+
+    /**
+     * @test
+     *
+     * @param list<Component> $components
+     * @param list<array{class: string, value: string}> $expectedRepresenation
+     *
+     * @dataProvider provideComponentsAndArrayRepresentation
+     */
+    public function setComponentsSetsComponentsProvided(array $components, array $expectedRepresenation): void
+    {
+        $subject = new Selector();
+
+        $subject->setComponents($components);
+
+        $representation = $subject->getArrayRepresentation()['components'];
+        self::assertSame($expectedRepresenation, $representation);
+    }
+
+    /**
+     * @test
+     *
+     * @param list<Component> $components
+     *
+     * @dataProvider provideComponentsAndArrayRepresentation
+     */
+    public function getComponentsReturnsComponentsSet(array $components): void
+    {
+        $subject = new Selector();
+        $subject->setComponents($components);
+
+        $result = $subject->getComponents();
+
+        self::assertSame($components, $result);
+    }
+
     /**
      * @test
      *
@@ -448,10 +533,22 @@ public function doesNotCleanupSpacesWithinAttributeSelector(): void
      */
     public function getArrayRepresentationIncludesClassName(): void
     {
-        $subject = new Selector('a');
+        $subject = new Selector();
 
         $result = $subject->getArrayRepresentation();
 
         self::assertSame('Selector', $result['class']);
     }
+
+    /**
+     * @test
+     */
+    public function getArrayRepresentationIncludesComponent(): void
+    {
+        $subject = (new Selector())->setComponents([new CompoundSelector('p.test')]);
+
+        $result = $subject->getArrayRepresentation();
+
+        self::assertSame('p.test', $result['components'][0]['value']);
+    }
 }
